Skip to content

Commit 776619e

Browse files
authored
Merge branch 'develop' into dvcorreia-patch-1
2 parents 592bb48 + f14d880 commit 776619e

9 files changed

Lines changed: 15 additions & 27 deletions

File tree

deployment/codefresh-test.yaml

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -13,25 +13,13 @@ steps:
1313
repo: '${{CF_REPO_OWNER}}/${{CF_REPO_NAME}}'
1414
revision: '${{CF_BRANCH}}'
1515
git: github
16-
post_main_clone:
17-
title: Post main clone
18-
type: parallel
19-
stage: prepare
20-
steps:
21-
- title: Cloning cloud-harness repository...
22-
type: git-clone
23-
stage: prepare
24-
repo: https://github.com/MetaCell/cloud-harness.git
25-
revision: '${{CLOUDHARNESS_BRANCH}}'
26-
working_directory: .
27-
git: github
2816
prepare_deployment:
2917
title: Prepare helm chart
3018
image: python:3.9.10
3119
stage: prepare
3220
working_directory: .
3321
commands:
34-
- bash cloud-harness/install.sh
22+
- bash install.sh
3523
- harness-deployment . -n test-${{NAMESPACE_BASENAME}} -d ${{DOMAIN}} -r ${{REGISTRY}}
3624
-rs ${{REGISTRY_SECRET}} -e test --write-env -N -i samples
3725
- cat deployment/.env >> ${{CF_VOLUME_PATH}}/env_vars_to_export

docs/accounts.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ in the application's values.yaml.
1515

1616
To assign paths and roles, set `uri_role_mapping` as you would do in the [gatekeeper configuration file resources](https://github.com/gogatekeeper/gatekeeper/blob/master/docs/content/configuration/_index.md).
1717

18+
1819
Example:
1920

2021
```yaml
@@ -27,7 +28,8 @@ harness:
2728
- administrator
2829
```
2930
30-
See the [Gogatekeeper official documentation](https://github.com/gogatekeeper/gatekeeper/blob/master/docs/content/userguide/_index.md) for more.
31+
32+
See the [Gogatekeeper official documentation](https://gogatekeeper.github.io/gatekeeper/userguide) for more.
3133
3234
3335
## Backend development

docs/dev.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ This file is part of the CloudHarness runtime.
9393
Other constants are located there as shown in the following code extract.
9494

9595
```python
96-
NODE_BUILD_IMAGE = 'node:8.16.1-alpine'
9796
APPLICATION_TEMPLATE_PATH = 'application-templates'
9897
# ...
9998
APPS_PATH = 'applications'
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
FROM node:15.5
1+
FROM node:20
22

33

install.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ CURRENT_PATH=$(pwd)
44
SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
55

66
cd $SCRIPT_DIR
7-
7+
pip install --upgrade pip
8+
cat requirements.txt
89
pip install -r requirements.txt
910

1011
cd $CURRENT_PATH

libraries/cloudharness-utils/cloudharness_utils/constants.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
import os
22

3-
NODE_BUILD_IMAGE = 'node:8.16.1-alpine'
4-
5-
6-
73
APPLICATION_TEMPLATE_PATH = 'application-templates'
84
DEFAULT_MERGE_PATH = ".overrides"
95

requirements.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
-e libraries/models
22
-e libraries/cloudharness-utils
33
-e tools/deployment-cli-tools
4-
4+
colorama<0.5.0,>=0.4.3
5+
typer<0.12.0

test/test-e2e/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM node:lts-slim
1+
FROM node:20
22

33
# Install latest chrome dev package and fonts to support major charsets (Chinese, Japanese, Arabic, Hebrew, Thai and a few others)
44
# Note: this installs the necessary libs to make the bundled version of Chromium that Puppeteer

tools/deployment-cli-tools/ch_cli_tools/codefresh.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -261,10 +261,11 @@ def add_unit_test_step(app_config: ApplicationHarnessConfig):
261261
image=image_tag_with_variables(app_name, tag, base_image_name),
262262
)
263263

264-
codefresh_steps_from_base_path(join(root_path, BASE_IMAGES_PATH), CD_BUILD_STEP_BASE,
265-
fixed_context=relpath(root_path, os.getcwd()), include=helm_values[KEY_TASK_IMAGES].keys())
266-
codefresh_steps_from_base_path(join(root_path, STATIC_IMAGES_PATH), CD_BUILD_STEP_STATIC,
267-
include=helm_values[KEY_TASK_IMAGES].keys())
264+
if helm_values[KEY_TASK_IMAGES]:
265+
codefresh_steps_from_base_path(join(root_path, BASE_IMAGES_PATH), CD_BUILD_STEP_BASE,
266+
fixed_context=relpath(root_path, os.getcwd()), include=helm_values[KEY_TASK_IMAGES].keys())
267+
codefresh_steps_from_base_path(join(root_path, STATIC_IMAGES_PATH), CD_BUILD_STEP_STATIC,
268+
include=helm_values[KEY_TASK_IMAGES].keys())
268269

269270
codefresh_steps_from_base_path(join(
270271
root_path, APPS_PATH), CD_BUILD_STEP_PARALLEL)

0 commit comments

Comments
 (0)