Four fixes: /issues empty state, sign-in fallback, FAQ a11y, missing mock profiles - #319
Open
chmm195 wants to merge 1 commit into
Open
Four fixes: /issues empty state, sign-in fallback, FAQ a11y, missing mock profiles#319chmm195 wants to merge 1 commit into
chmm195 wants to merge 1 commit into
Conversation
- /issues rendered a bare empty grid with no EmptyState, unlike every dashboard list, so a fresh deployment looked broken (MergeFi#274) - auth/callback wrapped CallbackClient in Suspense with no fallback, so the sign-in page was blank until the boundary resolved (MergeFi#265) - the FAQ accordion's decorative '+' had no aria-hidden, so screen readers announced a literal plus after the native summary state (MergeFi#268) - mockReputationProfiles covered 2 of the 5 topContributors handles, so three of the five homepage leaderboard links 404'd in demo mode (MergeFi#284) Closes MergeFi#274 Closes MergeFi#265 Closes MergeFi#268 Closes MergeFi#284
|
@chmm195 is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four small, independent fixes across the issues page, the sign-in callback, the homepage FAQ, and the mock data layer.
Closes #274, closes #265, closes #268, closes #284.
/issueshad no empty state (#274)The grid rendered bare when
bounties.length === 0, so a fresh deployment with nothing funded showed a heading, a paragraph promising escrow-backed bounties, and then nothing at all. Every dashboard list already usesEmptyStatefor exactly this. Now/issuesdoes too, with theInboxicon and copy that explains why it is empty rather than just stating that it is.Sign-in callback rendered nothing while suspending (#265)
<Suspense>had nofallback, so the window before the boundary resolved was blank.CallbackClient's own "Finishing sign-in…" only appears after it mounts, which is the gap. Added aCallbackFallbackwith a spinner and arole="status"message so the state is announced, not just drawn. The spinner itself isaria-hidden— it carries no information the text does not.FAQ "+" announced as a literal plus (#268)
<summary>already exposes expanded/collapsed natively, so the decorative+was pure noise after it. Markedaria-hidden="true". Verified in the prerendered output rather than by eye:Three of five leaderboard links 404'd in demo mode (#284)
topContributorslists five handles;mockReputationProfileshad two.devrel_ana,qa_marcusandlinh_devall 404'd when the backend was unreachable — and the homepage links to all five.Added the three missing profiles with
lifetimeEarnings/mergedPRsmatching their leaderboard rows exactly, so the profile page does not contradict the list that linked to it. The remaining fields follow the shape of the existing two. Checked mechanically that the two structures cannot drift again unnoticed:Verification
npm run lint— cleannpm run build— succeedsnpm test— 177 passed, 1 failed. The failure isNetworkBadge.test.tsx("hides the badge for a production build on PUBLIC"), which fails identically on a cleanmain. Unrelated to this PR and left alone;WalletContext/ConnectPanelsuites report as failed for the same pre-existing reason.I previously opened #311 and #312 against #237/#236 — both were fixed by bundled PRs that landed first, so I have closed mine. Bundling here to match how the queue actually moves.