fix: escrow sponsor/status index, dead stellar config removal, releasePartial/refund and SorobanClientService test coverage - #208
Merged
chonilius merged 1 commit intoAug 26, 2026
Conversation
…er releasePartial/refund and SorobanClientService
|
@hardcordev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@hardcordev is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added the missing composite index on
escrows(sponsorId, status), removed five dead Stellar config fields that were documented but never read, and filled two unit-test gaps: direct coverage forEscrowService.releasePartial()/refund()and a dedicated spec forSorobanClientService.Changes
@Index('IDX_escrow_sponsor_status', ['sponsorId', 'status'])on theEscrowentity plus a matching TypeORM migration (1784600000000-AddEscrowSponsorIdStatusIndex) servingSponsorsService.budgetLocked'ssponsorId+statusfilter.horizonUrl,maintenancePoolContractId,treasuryAddress,usdcAssetCode, andusdcAssetIssuerfields fromAppConfig/configuration.ts, their.env.exampleentries (HORIZON_URL,MAINTENANCE_POOL_CONTRACT_ID,TREASURY_ADDRESS,USDC_ASSET_CODE,USDC_ASSET_ISSUER), and the corresponding README documentation, so operators are no longer told to configure values nothing reads.describe('releasePartial')anddescribe('refund')blocks toescrow.service.spec.tscovering partial release staying LOCKED below the total, exact-completion flipping to RELEASED, a partial→partial cumulative completion sequence, over-request rejection with no chain call or writes, refund-when-not-LOCKED rejection, and a successful LOCKED→REFUNDED transition.src/escrow/soroban-client.service.spec.tsexercisingisConfigured()gating and dry-run invocation, the simulate → assemble → sign → send pipeline including simulation-failure and submission-error paths,pollTransaction's NOT_FOUND retry-then-resolve and timeout behavior via fake timers, and all fourtoScValencoding branches (Stellar address, bigint/i128, plain string, number), using the existing stellar-sdk mock as the RPC double.Issues
Resolves #97
Resolves #96
Resolves #95
Resolves #94
Verification
Verified by manual code review of the full diff against the service implementations, entity/migration conventions, jest config, and the existing stellar-sdk mock.
cargo buildandcargo testwere not run.