fix: enable SQLite foreign key enforcement in get_dialect() - #620
Open
Tusm11 wants to merge 1 commit into
Open
Conversation
Contributor
|
@Tusm11 we're working on exciting new features and will review this soon. Join our Discord community to be the first to hear about the latest releases! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SQLite disables foreign key constraint enforcement by default. This causes ON DELETE CASCADE constraints to be silently ignored, leaving orphaned rows in
memori_entity_fact_mentiontable afterdelete_entity_memories()is called.Example scenario:
delete_entity_memories(entity_id)Solution
Execute
PRAGMA foreign_keys = ONwhen SQLite dialect is detected in theget_dialect()method. This enables proper foreign key constraint enforcement, making cascade deletes work as intended.Changes Made
Testing
uv run pytest tests/storage/drivers/test_sqlite_driver.py -vImpact