fix(memory): reject empty entity IDs during deletion - #613
Open
krishna28004 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a data-loss edge case in
delete_entity_memories()where passing an empty string ("") could incorrectly fall back to the configured default entity due to Python truthiness.Related issue
N/A
Before opening this PR
Affected components
memori/)How was this tested?
uv run pytestuv run ruff check .uv run ruff format --check .Checklist
Notes for reviewers
This PR adds an explicit validation for empty entity IDs at the public API boundary and replaces the internal truthiness fallback with an explicit
is not Nonecheck. A regression test has been added to prevent the data-loss scenario from recurring.