feat: support unstreamed Bedrock responses (Converse & Messages API) - #565
feat: support unstreamed Bedrock responses (Converse & Messages API)#565SHAURYASANYAL3 wants to merge 5 commits into
Conversation
…roject.toml - Support Converse API, Messages API, and legacy completion formats for unstreamed Bedrock responses. - Wrap unstreamed responses in a list in StreamingBody.read for adapter consistency. - Add unit tests for all newly supported unstreamed Bedrock formats. - Modernize pyproject.toml license declaration to SPDX string and remove deprecated classifiers.
|
Thanks for adding this. The implementation looks good for the response shapes it targets, and the added tests cover Converse-style This is a step in the right direction for supporting Bedrock streaming. Please correct the linting issues and we can proceed with the review process. |
- Fix indentation and duplication in .github/workflows/ci.yml - Rename .env.example to .env.template across the repository - Run ruff format on Python files - Run eslint and prettier on TypeScript files - Add missing scripts and package-lock.json - Update run-linters.sh to be more resilient
|
@devwdave i have fixed that lint issue once check if still the errors comes again i will work on it |
|
It looks like your update includes a lot of changes outside the scope of the Bedrock adapter work, including CI/workflow updates, repo-wide env template renames, linting/pre-commit changes, changelog updates, docs formatting changes, and TypeScript-related files. Those may be valid improvements, but they make this PR harder to review safely and increase the risk of merging unrelated behavior changes. Can you please narrow this PR to only the Bedrock unstreamed response parsing work and the directly related tests? Any broader cleanup or repository-wide standardization should be split into separate PRs so we can review those changes independently. Once this is scoped down, I’m happy to take another look. |
|
Hi @SHAURYASANYAL3, We're very grateful for your contribution and would like to invite you to our Discord! You'll be able to:
Looking forward to working with you on improving Memori. Jay |
This PR addresses an explicit REQUEST FOR CONTRIBUTION in the AWS Bedrock adapter by implementing unstreamed response
parsing. It also includes repository-wide standardization for environment templates, linting, and formatting to ensure
consistent CI/CD and developer experience.
Changes
list. This ensures structural consistency with how the SDK's adapters expect response payloads.
deprecated classifiers to resolve setuptools build warnings.
tests/llm/adapters/bedrock/test_llm_adapters_bedrock_adapter.py to verify all supported formats.
Checklist
All changes have been committed and pushed to origin/main.