fix(node_info): do not show() the UPS widget from its renderer - #319
Open
OiCkilL wants to merge 1 commit into
Open
fix(node_info): do not show() the UPS widget from its renderer#319OiCkilL wants to merge 1 commit into
OiCkilL wants to merge 1 commit into
Conversation
Calling this.show() during StatusView.updateField races Ext's table layout (e.set is not a function) and aborts the rest of the summary panel. The widget is already visible; only toggle the progress bar.
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #310.
On 1.0.7 the node summary can stall after Primary Metrics: UPS Status shows only the title, later widgets never paint, and the console throws:
PVE.node.StatusViewis a 2-column table layout. The UPS widget replacespmxInfoWidgetinternals with nested containers + a progressbar. The renderer (invoked fromupdateFieldwhile the store loads) calledthis.show()even for an empty first payload (PveMod_upsInfois{}until the collector writesups.json). Thatshow()flushes layouts mid-updateValues, and Ext's table layout hitse.set is not a function. RemainingpmxInfoWidgets never update.The comment already says the renderer should not touch the DOM. This removes
this.show()/this.hide()from it and only togglessetPrintBar.Tested by applying the same one-hunk change on a 1.0.7 host; summary widgets and the UPS row render after a hard refresh.