Repository navigation
fix(client): don't draw the walk marker at the view centre when the destination is off-screen - #78
Open
CakeRepository wants to merge 1 commit into
Open
CakeRepository wants to merge 1 commit into
CakeRepository wants to merge 1 commit into
Conversation
…estination is off-screen Client.walkTo fell back to (256, 166) for the yellow walk cross when projectTileToScreen returned null. Most SDK walks go further than the visible view, so the marker flashed in the middle of the game screen, which reads as a click on whatever stands there. Draw the marker only when the destination projects on screen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client.walkTofalls back to (256, 166) for the yellow walk cross whenprojectTileToScreenreturns null. Most SDK walks go further than the visible view, so the marker flashes in the middle of the game screen, which reads as a click on whatever stands there. We noticed it watching an agent play, and it also misleads anything that reads the screen.This draws the marker only when the destination projects on screen. Walks to visible tiles look the same as before.
Checks (Windows 11, bun 1.4.2):
bun run typecheckandbun run typecheck:webclientpass.bun run test: 299 pass / 26 fail, the same tests with and without this change on currentmain. The failures predate it on this machine (DOM-less tests such asdocument is not defined, plus timing-sensitive tests).🤖 Generated with Claude Code