9k: eliminate _g wrappers — Bochner stack fully explicit-g#47
Merged
Conversation
* Lift `bochner_leibniz_trace_reduction` and `bochner_weitzenboeck` in `Operators/Bochner.lean` to take `(g : RiemannianMetric I M) (hg : g = hm.metric)`; insert `subst hg` at body start. Existing proof bodies untouched. * Delete `bochner_leibniz_trace_reduction_g`, `bochner_weitzenboeck_g`, `bochner_connectionLaplacian_grad_decomposition_g` — the explicit-g forms are now the primary theorems. * `connectionLaplacian` def body: replace `smoothOrthoFrame hm.metric` with `smoothOrthoFrame g` so the orthoframe is consistent with the section variable `g`. * `tangentHyperplane_at_reducedBoundary_orthogonal` (sorry-bearing pre- paper axiom): lift statement from `HasMetric.metric.metricInner` to explicit `(g : RiemannianMetric I M)`. After this PR, zero `_g`-suffixed declarations remain across OpenGALib. Sorry / linter / shake baselines unchanged.
The `@[simp] rfl` lemma `connectionLaplacian_def` in `Util/ConnectionLaplacianSimp.lean` had a stale RHS still spelling `smoothOrthoFrame hm.metric` after the def body in `Operators/ConnectionLaplacian.lean` was unified to `smoothOrthoFrame g`. Local incremental build re-used the cached olean so the rfl mismatch only surfaced in fresh-elaboration CI. Update RHS to `g` so def-eq holds.
This was referenced May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bochner_leibniz_trace_reduction,bochner_weitzenboeck) to take explicit(g : RiemannianMetric I M) (hg : g = hm.metric); insertsubst hgat body start._gwrappers (bochner_leibniz_trace_reduction_g,bochner_weitzenboeck_g,bochner_connectionLaplacian_grad_decomposition_g) — the explicit-g forms are now primary.connectionLaplaciandef body now usessmoothOrthoFrame g(wassmoothOrthoFrame hm.metric) for consistency with the section varg.tangentHyperplane_at_reducedBoundary_orthogonal(sorry-bearing pre-paper axiom) statement lifted fromHasMetric.metric.metricInnerto explicitg.After this PR, zero
_g-suffixed declarations remain across OpenGALib. The explicit-g cascade (umbrella #9) is fully concluded for the active proof surface; remainingHasMetric.metricreferences in statement types are limited to (a)IsStationary/IsStable/IsUnstable(architectural quantified-Prop choice) and (b)SmoothOrthoFramelemmas tightly coupled to the typeclass metric.Test plan
lake build OpenGALib.Riemannian.Operators.Bochnerclean (2903/2903)lake build OpenGALibclean (no new errors, only pre-existing sorry warnings)docs/SORRY_CATALOG.md)