Skip to content

[WIP] bump rubocop to 1.68.0 - #56

Closed
kbrock wants to merge 1 commit into
ManageIQ:masterfrom
kbrock:bump_robocop
Closed

kbrock wants to merge 1 commit into
ManageIQ:masterfrom
kbrock:bump_robocop

Conversation

@kbrock

@kbrock kbrock commented Nov 11, 2024

Copy link
Copy Markdown
Member

Main goal is to drop rexml dependency

WIP: want to fix some warnings before pushing this forward

@miq-bot cross-repo-test /all

This no longer depends upon rexml.
Rexml has been showing a number of CVEs recently, so it would be nice
to get away from it. At least as a transitive dependency.
(we still depend upon it for some of our code)
@Fryguy

Fryguy commented Nov 11, 2024 •

Copy link
Copy Markdown
Member

This is completely based on what's available from code climate. There is a rake task here that will pull the latest and update all the things.

EDIT: Sorry, I was slightly wrong - there's code in here to detect it, but it's not in a rake task. That being said, the list is basically this https://github.com/codeclimate/codeclimate-rubocop/branches/all?query=channel, which as you can see the latest channel is 1.56.3.

@Fryguy

Fryguy commented Nov 11, 2024

Copy link
Copy Markdown
Member

We could possibly move to channel/beta - not sure what that would entail from other configuration things. See also qltysh-archive/codeclimate-rubocop#374

@kbrock

kbrock commented Nov 12, 2024

Copy link
Copy Markdown
Member Author

Holding off and will upgrade once Code Climate updates

@kbrock kbrock closed this Nov 12, 2024
@kbrock
kbrock deleted the bump_robocop branch November 12, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants