ci: stop the demo workflow pushing to master - #67
Merged
Conversation
Two bugs, both mine. The workflow committed the rendered GIF straight to master. The master ruleset requires changes to go through a pull request, so the push was rejected with GH013 and the job went red on every run. Second, the check it used to decide whether to push could never be false: VHS renders the migration filename from the current timestamp, so the bytes differ on every run. Even with the push working, this would have churned a 175K binary into git history on every trigger. The GIF is a yearly-ish manual update, not something worth automating into the default branch. The workflow now renders the tape and uploads the result as an artifact — it verifies the tape still works and hands you a fresh GIF to commit through a normal PR. Dropped contents: write, it no longer needs it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Demo GIF workflow has been red on master since the merge of #66. Two bugs, both introduced there.
It pushed straight to master. The master ruleset requires changes to go through a pull request, so the push was rejected:
Its "did anything change?" guard could never be true. VHS renders the migration filename from the current timestamp, so the GIF bytes differ on every run. Even with the push working, every trigger would have committed a fresh 175K binary to master.
The GIF changes when the CLI output changes — roughly never. Automating that into the default branch was the wrong call. Now the workflow renders the tape and uploads the result as an artifact: it still catches a tape that silently stopped working, and hands you a fresh GIF to commit through a normal PR.
contents: writedropped, it no longer needs it.The committed
assets/demo.gifis unchanged and still correct.🤖 Generated with Claude Code