feat:增加角色卡配置 override & 多语言 - #213
Conversation
🔍 PR Test Report🧪 Test Results✅ All tests passed!
📊 Coverage Report
Coverage Thresholds
Generated at 2026-08-08T03:59:57.853Z |
|
慢慢看... |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 40612ab147
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
LGFM |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 185c03875e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
LGFM |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 629ab8c3b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (target_entry) { | ||
| entry_uid = target_entry.uid; | ||
| Object.assign(target_entry, { | ||
| name: CHARACTER_SETTINGS_OVERRIDE_ENTRY_NAME, | ||
| content, | ||
| enabled: false, |
There was a problem hiding this comment.
If another editor saves the configuration after the initial loadRawWorldbook conflict check but before this updateWorldbookWith callback runs, the callback receives that newer worldbook and unconditionally overwrites its target without prompting. The same race overwrites a newly created matching entry when entry_uid was null. Validate the target's expected state against the worldbook supplied to the updater before assigning content, so changes made during this gap are handled as conflicts.
Useful? React with 👍 / 👎.
1 participant
rt