Repository navigation
Conversation
MYSTRAVIL
added a commit
that referenced
this pull request
Sep 27, 2026
…); ask options declare object items for strict providers Reworked from #20 and #21 by @Errnolink. Co-authored-by: Errnolink <Errnolink@users.noreply.github.com>
Owner
|
Thanks, your diagnosis was right: the extra row was a regression from the #8 keying. Landed reworked in 769babb (you're credited as co-author):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19.
What happens
Wire capture from a phone-connected session (one plain turn, no steering):
omp fires one more
message_updatecarrying the final full snapshot after the assistantmessage_end.FeedMsgIdsis doing its documented job — afterend()closed occurrence 1,id()for the same role+timestamp allocates occurrence 2 — so the bridge emits astartfor a brand-new row with identical text and the phone renders the reply twice. Reproduced on every text reply in 3/3 fresh sessions.Fix
The bridge records each ended assistant row (
timestamp → {msgId, text}). A post-end update whose text is identical to the ended frame is omp's trailing snapshot repeating itself — swallow it. Text equality is the discriminator available here (the bridge sees nomessage_start): a genuine second reply that merely shares the millisecond starts from different text and falls through tofeedIds.id()as before, keeping its own row — exactly the case the existing same-millisecond test pins.Testing
packages/bridge/test/session-switch.test.ts.bun test packages/bridge: 95 pass, 0 fail.tsc --noEmitclean.Caveat
If omp ever emits a post-end update with different text, this opens occurrence 2 (pre-fix behavior) rather than amending the ended row. That signature has not been observed — every captured trailing snapshot matched the ended text — and the alternative (unconditional in-place update) breaks the same-millisecond second-reply semantics the test suite defines.