fix: quote a --flag=value from the equals sign, not from the start - #5
Merged
Merged
Conversation
A shell hands godo one argument, so --am="two words" arrives whole and was quoted whole: git commit '--am=two words'. That reads as though the flag name were part of the message, which is a bad look for a tool whose feature is showing you the command before it runs. Quoting only the value — --am='two words' — is the same single argument to the shell and is what a person would have typed. A test runs both through sh and asserts the argument that arrives is byte-identical, so this stays a rendering change and nothing more. Only applies when the prefix is a real flag (-f= / --flag=) and inert on its own; 'am=two words' and '--=x y' are still quoted whole. A value like '--am-two words' has no delimiter to split on and is left alone — '=' is a delimiter, '-' is not, and inventing a split point would be godo inventing structure that is not there.
This was referenced Sep 20, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A shell hands godo one argument, so
--am="two words"arrives whole and was quoted whole:Same single argument to the shell. A test runs both through
shand asserts the argument that arrives is byte-identical, so this is a rendering change and nothing more.Only applies when the prefix is a real flag (
-f=/--flag=) and inert on its own —am=two wordsand--=x yare still quoted whole.--am-two wordshas no delimiter to split on and is left alone:=is a delimiter,-is not.First of a two-PR stack; #runner-axis builds on this.
Checklist
./godo cipasses locally