Conversation
Document indication-specific ORR–PFS regression in README
Update README installation instructions
…testing-get_beta_params.R
Treat omega as a random variable
Add indication-specific regression model
Add indication-specific model
Update URL
Update URL
Update omega
Add indication-specific coefficients
Add single-arm ORR setting
Add reference
Add references
Add single-arm setting
- Delete src/ directory (cleanup, cleanup.win, Makevars, install.libs.R,
stan/ copies) -- these were generated by instantiate::stan_package_configure()
and are no longer needed
- Remove stale src/stan/*.rds entry from .Rbuildignore
- Add R/globals.R with globalVariables() to suppress R CMD check NOTEs
for NSE variables in gen_pos (omega, pos, reject, theta_P3_hat)
- Add R/stan_platform.R with two-tier Stan model cache:
tier 1: inst/stan/precompiled/<platform_key>/ (bundled, read-only)
tier 2: tools::R_user_dir('oncoPoS', 'cache')/<platform_key>/ (user-writable)
Fixes recompilation every session on Linux system library installs
- Fix non-ASCII em/en dash characters in roxygen comments across gen_pos.R,
run_stan.R, and stan_platform.R (caused devtools::document() UTF-8 error)
yuliasidi
reviewed
Jun 4, 2026
yuliasidi
left a comment
yuliasidi
left a comment
Collaborator
There was a problem hiding this comment.
@ShunRao8 , were you able to reproduce the mean(posterior_draws$sigma_wls) number based on the published data?
If, yes, I will approve the PR. You can see in the commit history some minor changes + updates for installing this more smoothly on Windows
Collaborator
Author
|
@yuliasidi Thank you! Yes, I was able to reproduce the value. Ready for your approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_beta_params()resp2oddsratio_estimate_ctrl()