Add error messages to kmcurvely() when endpoints or subgroup is not defined in the metadata - #34
Merged
Merged
Conversation
… defined in metadata
Closed
Closed
Comment on lines
+105
to
+108
| has_parameter_mapping <- function(name) { | ||
| mapping <- metalite::collect_adam_mapping(meta, name) | ||
| !is.null(mapping$subset) && !is.null(mapping$label) | ||
| } |
Collaborator
There was a problem hiding this comment.
If an additional function is required, it would be better to define it outside of this function as a helper function, or place it in a separate file (e.g., utils.R) with @noRd.
Collaborator
Author
There was a problem hiding this comment.
For now, this function will remain as a local utility within the kmcurvely module, as that is currently its only use case.
This is a temporary solution. If this function is needed in other parts of the codebase in the future (i.e., if it is called more frequently), we should refactor it into a more general, shared utility module to avoid code duplication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To solve issue #33