22 add legend to the hr forest plot - #28
Merged
Merged
Conversation
LittleBeannie
approved these changes
Oct 28, 2025
LittleBeannie
left a comment
LittleBeannie
left a comment
Collaborator
There was a problem hiding this comment.
Thank you, @fukuhiro2023! I approve.
One minor comment: can we name digits_km_curves as digits_surv? This is because there are many numbers in the KM plots, and we are only adjusting the y-axis of the KM plots, which is the survival over time.
Collaborator
Author
Thanks for your review. Sure, I have updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes:
format_hr_forestlyand related functions to add a legend for HR forest plot.digits_km_curvestoformat_hr_forestlyso that users can control the disply digits of survival probability in KM curves.drigitsinformat_hr_forestlytodigits_hrfor clarificationUpdated output