Repository navigation
Conversation
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the create/edit integration dialog, the "Integration title" field is required: the input has the
requiredattribute and the dialog shows an error when it is left blank. However, the label gives no visual indication that the field is required, so users only learn this after submitting.Change
src/components/dialog/IntegrationDialog.vue: append*to the integration title label, the same marker the observation title label uses inObservationDialog.vue.Testing
Added
tests/component/IntegrationDialog.spec.ts, which mounts the dialog and asserts the title label ends with*.npx vitest --environment jsdom run tests/component/IntegrationDialog.spec.ts: 1 passednpx eslint --max-warnings=0 src/components/dialog/IntegrationDialog.vue tests/component/IntegrationDialog.spec.ts: no lint errorsRegression test: added; see Testing above.
Fixes #291