Skip to content

ci: block Pages deploy when site reference check fails - #1

Merged
MJorgin merged 1 commit into
mainfrom
ci/gate-pages-deploy-on-site-check
Sep 18, 2026
Merged

MJorgin merged 1 commit into
mainfrom
ci/gate-pages-deploy-on-site-check

Conversation

@MJorgin

@MJorgin MJorgin commented Sep 18, 2026

Copy link
Copy Markdown
Owner

背景

run 35203283375 中 CI 的 site-links 检查失败,但同一提交的 Pages 部署照常成功——因为 pages.yml 独立于 ci.yml 触发,部署前不做任何站点完整性校验。这次只是 checker 自身的 bug,属于侥幸;若将来推上 main 的提交真的有断链或缺文件,坏页面会先上线。

改动

在 pages.yml 的 checkout 之后、stage/upload 之前增加:

  • setup-node@v4(Node 20,与 ci.yml 保持一致)
  • node scripts/check_site.mjs(与 CI 同一个检查:断链、缺失引用、deck 字节一致)

检查失败则整个 deploy job 直接退出,不会上传/部署 artifact。

不做的事

  • 没有改用 workflow_run 或加 branch protection(个人项目过重);
  • 没有把 dsh-manifest、playwright verifier 搬进部署流程——它们校验的是技能包/渲染质量,不是站点可发布性。

@MJorgin
MJorgin merged commit ea17c8a into main Sep 18, 2026
3 checks passed
@MJorgin
MJorgin deleted the ci/gate-pages-deploy-on-site-check branch September 18, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants