Stellar Security Rule Regression Suite#518
Open
deslawson wants to merge 2 commits into
Open
Conversation
Implemented a regression testing framework under tests/regression/security/stellar/ that prevents security rule regressions across releases. The suite includes 8 JSON fixture datasets (one per rule variant) covering all 5 Stellar/Soroban security detectors — missing access control, weak role hierarchies, unsafe cross-contract invocation, excessive event topics, and missing upgrade guards. Each fixture contains realistic Soroban contract code with known-vulnerable and known-safe patterns, paired with expected findings. The Jest spec file performs automated validation: positive fixtures assert detected=true with matching message patterns, negative fixtures assert detected=false. CI integration was added via a regression-tests job in .github/workflows/ci.yml, npm scripts (test:regression:stellar), and batch automation scripts for both Unix and Windows. All 8/8 fixtures verified passing against their respective detectors.
Collaborator
|
Hi @deslawson , thanks for your contribution. Please kindly fix the remaining ci that are failing. |
Collaborator
|
Hello @deslawson , you'll be unassigned in the 12hrs if you didn't fix the errors as requested. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented a regression testing framework under tests/regression/security/stellar/ that prevents security rule regressions across releases. The suite includes 8 JSON fixture datasets (one per rule variant) covering all 5 Stellar/Soroban security detectors — missing access control, weak role hierarchies, unsafe cross-contract invocation, excessive event topics, and missing upgrade guards. Each fixture contains realistic Soroban contract code with known-vulnerable and known-safe patterns, paired with expected findings. The Jest spec file performs automated validation: positive fixtures assert detected=true with matching message patterns, negative fixtures assert detected=false. CI integration was added via a regression-tests job in .github/workflows/ci.yml, npm scripts (test:regression:stellar), and batch automation scripts for both Unix and Windows. All 8/8 fixtures verified passing against their respective detectors.