Repository navigation
fix(playerbots): initialize creature spawn instance fields - #83
Merged
Merged
Conversation
Contributor
Author
|
Merged with LyraCoreProject/LyraCore#688. The required Module check passed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The full-world creature import adds
instance_idandsource_guidto Core'sCreatureSpawntype. Ten playerbot fixtures construct that type directly and no longer compile.Initialize both fields. Shared-world fixtures use Instance zero. The transfer destination fixture keeps its existing Instance ID. Each fixture uses
source_guid = 0because it creates the spawn directly.Verified formatting, the Package API check and the all-Packages Wasm compile through
.github/check-core-tip.shagainst the paired Core branch. This change must land with Core PR #688.Made with GPT-6 Astra through the Codex harness in T3 Code.