perf(gateway): read Character state through maintained indexes

.github/workflows/module-durable.yml

@@ -85,6 +85,7 @@ jobs:
           cargo test -p lyracore-gateway --test provision_cli provision_writes_the_account_to_the_world_shard_and_realm_core -- --ignored --exact
           cargo test -p lyracore-gateway --test startup_relays -- --ignored --test-threads=1
           cargo test -p lyracore-gateway --test notification_events -- --ignored --test-threads=1
+          cargo test -p lyracore-gateway --bin lyracore-gateway stdb::reads::indexed_durable_tests -- --ignored --test-threads=1
           cargo test -p lyracore-gateway --bin lyracore-gateway stdb::world_view::item_durable_tests::live_worn_item_insert_enchant_and_delete_reach_a_nearby_peer -- --ignored --exact
 
       - name: Run Benilla against private Module instances

docs/architecture.md

@@ -596,9 +596,13 @@ The SDK cache has only unique-index finders, and a whole-table `iter()` copies e
 lock the pump needs. So relays and per-request reads use Gateway-side indexes, each kept from its
 table's insert, update and delete callbacks and registered before the subscription applies:
 `PartyMembershipIndex`, `ChannelIndex`, `GuildIndex`, `MailEscrowIndex`, `AuctionIndex`,
-`ContactIndex` (owner to friends and ignores) and `CharacterNameIndex` (lowercase name to guid,
-per Shard). Each lives on its connection generation, so a reconnect rebuilds it from the fresh
-subscription.
+`ContactIndex`, `CharacterNameIndex`, and indexes for inventory, skills, quest progress, loot
+entitlement, target auras and enchantment effects. Each lives on its connection generation, so a
+reconnect rebuilds it from the fresh subscription. Indexed inventory and projection reads hold a
+snapshot read guard. The pump holds the write guard only while polling an SDK update, so these reads
+see both the committed cache and all of that update's index callbacks. The guard releases while the
+SDK awaits network input. Pump callbacks enqueue these guarded projections instead of reading them
+synchronously.
 
 Combat, spell cast, spell impact, Speech and emote notifications use native `*_event_live` tables.
 The ordinary predecessors retain their published schemas for additive upgrades and expire through the

gateway/src/codec/combat/subscriptions.rs

@@ -375,9 +375,8 @@ pub(crate) fn armor_packet(
         return None;
     }
     let guard = coord.0.coord();
-    let db = &guard.conn.db;
-    let eff = crate::stdb::armor::effective_resistances(db, self_guid);
-    let pos = crate::stdb::armor::aura_armor_positive(db, self_guid);
+    let eff = crate::stdb::armor::effective_resistances(&guard, self_guid);
+    let pos = crate::stdb::armor::aura_armor_positive(&guard, self_guid);
     Some(Outbound::One(ServerOpcodeMessage::SMSG_UPDATE_OBJECT(
         Box::new(codec::build_armor_values(self_guid, eff, pos)),
     )))

gateway/src/codec/entity/subscriptions.rs

@@ -11,6 +11,7 @@ use crate::stdb::views::entity_view;
 use crate::stdb::world_index::{CellKey, EntityLayer, SessionId, ShardId};
 use crate::stdb::world_view::*;
 use crate::stdb::Coordinator;
+use crate::stdb::LiveConn;
 use crate::world::Outbound;
 use anyhow::Result;
 use lyracore_shared::spatial::BOX_HALF_SPAN;
@@ -39,7 +40,7 @@ pub(crate) fn build_peer_create(
         };
     let view = peer_entity_view(
         row,
-        projected_dynamic_flags(&coord.0.coord().conn.db, viewer_guid, row),
+        projected_dynamic_flags(&coord.0.coord(), viewer_guid, row),
         |guid| guild_projection_of(coord, guid),
     );
     let auras = world.auras.on_target(shard, row.guid);
@@ -151,9 +152,9 @@ pub(crate) fn peer_create_outbound(
 struct LootTagProjectionRows<'a> {
     tap: Option<&'a CreatureQuestTap>,
     tag_group: Option<&'a CreatureLootTagGroup>,
-    tag_members: &'a [CreatureQuestTapMember],
-    current_members: &'a [GroupMember],
-    corpse_eligible: &'a [CorpseLootEligible],
+    tag_member: bool,
+    current_member: bool,
+    corpse_eligible: bool,
 }
 
 fn viewer_relative_dynamic_flags(
@@ -164,11 +165,7 @@ fn viewer_relative_dynamic_flags(
     use lyracore_shared::constants::unit_dynamic_flags::{LOOTABLE, TAPPED_BY_PLAYER};
 
     if entity.dead {
-        return if rows
-            .corpse_eligible
-            .iter()
-            .any(|row| row.corpse_guid == entity.guid && row.eligible_guid == viewer_guid)
-        {
+        return if rows.corpse_eligible {
             entity.dynamic_flags
         } else {
             entity.dynamic_flags & !LOOTABLE
@@ -182,13 +179,7 @@ fn viewer_relative_dynamic_flags(
         .tag_group
         .filter(|group| group.creature_guid == entity.guid)
     {
-        Some(group) => {
-            rows.tag_members.iter().any(|member| {
-                member.creature_guid == entity.guid && member.character_guid == viewer_guid
-            }) && rows.current_members.iter().any(|member| {
-                member.character_guid == viewer_guid && member.group_id == group.group_id
-            })
-        }
+        Some(_) => rows.tag_member && rows.current_member,
         None => viewer_guid == tap.character_guid,
     };
     if entitled {
@@ -199,44 +190,38 @@ fn viewer_relative_dynamic_flags(
 }
 
 pub(crate) fn projected_dynamic_flags(
-    db: &RemoteTables,
+    live: &LiveConn,
     viewer_guid: u64,
     entity: &WorldEntity,
 ) -> u32 {
-    let tap = db
-        .game_creature_quest_tap()
-        .creature_guid()
-        .find(&entity.guid);
-    let tag_group = db
-        .game_creature_loot_tag_group()
-        .creature_guid()
-        .find(&entity.guid);
-    let tag_members: Vec<_> = db
-        .game_creature_quest_tap_member()
-        .iter()
-        .filter(|member| member.creature_guid == entity.guid)
-        .collect();
-    let current_members: Vec<_> = db
-        .game_group_member()
-        .iter()
-        .filter(|member| member.character_guid == viewer_guid)
-        .collect();
-    let corpse_eligible: Vec<_> = db
-        .game_corpse_loot_eligible()
-        .iter()
-        .filter(|eligible| eligible.corpse_guid == entity.guid)
-        .collect();
-    viewer_relative_dynamic_flags(
-        viewer_guid,
-        entity,
-        LootTagProjectionRows {
-            tap: tap.as_ref(),
-            tag_group: tag_group.as_ref(),
-            tag_members: &tag_members,
-            current_members: &current_members,
-            corpse_eligible: &corpse_eligible,
-        },
-    )
+    live.with_cache_snapshot(|| {
+        let db = &live.conn.db;
+        let tap = db
+            .game_creature_quest_tap()
+            .creature_guid()
+            .find(&entity.guid);
+        let tag_group = db
+            .game_creature_loot_tag_group()
+            .creature_guid()
+            .find(&entity.guid);
+        let loot_tags = live.loot_tags.read().unwrap();
+        viewer_relative_dynamic_flags(
+            viewer_guid,
+            entity,
+            LootTagProjectionRows {
+                tap: tap.as_ref(),
+                tag_group: tag_group.as_ref(),
+                tag_member: loot_tags.is_tap_member(entity.guid, viewer_guid),
+                current_member: tag_group.as_ref().is_some_and(|group| {
+                    live.party_memberships
+                        .read()
+                        .unwrap()
+                        .contains(viewer_guid, group.group_id)
+                }),
+                corpse_eligible: loot_tags.is_corpse_eligible(entity.guid, viewer_guid),
+            },
+        )
+    })
 }
 
 pub(crate) fn instance_relay_gate(row_instance_id: u64, viewer_instance_id: Option<u64>) -> bool {
@@ -398,7 +383,7 @@ pub(crate) fn relay_entity_update(
     }
     let dynamic_flags = {
         let guard = coord.0.coord();
-        projected_dynamic_flags(&guard.conn.db, viewer.self_guid, new)
+        projected_dynamic_flags(&guard, viewer.self_guid, new)
     };
     let mut out: Vec<Outbound> =
         entity_update_to_outbound_with_dynamic_flags(old, new, dynamic_flags)
@@ -479,7 +464,7 @@ pub(crate) fn loot_tag_flags_after_membership_change(
             Outbound::One(ServerOpcodeMessage::SMSG_UPDATE_OBJECT(Box::new(
                 codec::build_dynamic_flags_values(
                     entity.guid,
-                    projected_dynamic_flags(&guard.conn.db, viewer.self_guid, &entity),
+                    projected_dynamic_flags(&guard, viewer.self_guid, &entity),
                 ),
             )))
         })
@@ -963,9 +948,17 @@ pub(crate) mod tests {
             LootTagProjectionRows {
                 tap,
                 tag_group,
-                tag_members,
-                current_members,
-                corpse_eligible,
+                tag_member: tag_members.iter().any(|member| {
+                    member.creature_guid == entity.guid && member.character_guid == viewer_guid
+                }),
+                current_member: tag_group.is_some_and(|group| {
+                    current_members.iter().any(|member| {
+                        member.character_guid == viewer_guid && member.group_id == group.group_id
+                    })
+                }),
+                corpse_eligible: corpse_eligible
+                    .iter()
+                    .any(|row| row.corpse_guid == entity.guid && row.eligible_guid == viewer_guid),
             },
         )
     }