Repository navigation
docs: cut stale design notes and fix the security report channel - #694
Merged
Merged
Conversation
Remove the two implemented design notes and keep their lasting rules as comments next to the code. Remove the dated verification record and fixed counts from the Benilla doc and link it from testing.md. Tighten SUPPORT.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GitHub private vulnerability reporting is off for this repository, so the advisory links led nowhere. Point SUPPORT.md, CONTRIBUTING.md and the issue templates at a private message to a maintainer on the Discord server. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Some documents in
docs/record work that is already done. The two notes indocs/design/describe an item GUID allocator and a loot roll promotion that are both in the code, plus a rollout checklist for each. No document linked to them.docs/benilla-compatibility.mdended with the test results of one past run, and its request counts were going stale. Nothing linked to it either.SUPPORT.md,CONTRIBUTING.mdand the issue templates told people to report a security problem through GitHub private vulnerability reporting. That feature is off for this repository, so those reports had nowhere to go.This change:
docs/design/. The rules that still matter are now comments next to the code: the item GUID bit layout inmodule/src/items/guids.rs, and the receipt ordering and expiry rules inmodule/src/loot/rolls.rs.docs/benilla-compatibility.md, and links it fromdocs/testing.md.SUPPORT.md, and moves the conduct line out of the out-of-scope list.What you verified
rustfmt --checkon the two changed Rust filescargo check -p lyracore-moduleWhat you did NOT verify
Only comments changed in the Rust files, so I did not run the test suites.
Made by Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code