Repository navigation
fix(gameobject): scope pools to imported instance maps - #693
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An instance Shard without terrain or navigation was treated as a fresh Shard, so world fixture pools could activate there. Pool activation now also reads the imported creature-map registry to limit candidates to imported maps.
What you verified
The new private Standalone test failed before the fix and passed after it. A live instance import then kept world pool fixtures dormant. Module library tests: 1,698 passed.
Validation across the four repair commits: importer 446 passed; Module 1,698 passed; Gateway 2,172 passed; shared 310 passed; test support 15 passed; the new durable pool test passed. Importer formatting and Clippy passed. Production publish and all three full import profile checks passed.
What you did NOT verify
No new interactive client login was performed. Full workspace Clippy was not rerun locally; CI runs the repository checks.
Risk
Pool eligibility changes on imported Shards. No schema or protocol change.
Model and harness: GPT-6.1-sol through Codex in T3 Code.