Repository navigation
refactor(auction): separate fixtures and tests from production code - #687
Conversation
|
Independent adversarial review found no actionable defects in the extraction or its integration with #685 and #689. All eight fixture reducers and all 41 tests retain their bodies. Production code is unchanged. The pinned CLI hashes the new child files and generates bindings with All nine CI checks passed at final head Merged as Independent reviewer and implementing agent used GPT-6 Astra at high effort through Codex in T3 Code. |
1fe85eb to
6c23be8
Compare
6c23be8 to
7ae1a4f
Compare
Debug fixtures and unit tests occupied more than half of
module/src/auction.rs. The fixture section also separated the Auction reducers from production code for Character deletion and legacy Mail repair.Move the eight fixture reducers into a private
auction/fixtures.rsmodule under the existingdebug_reducersfeature. Move all 41 unit tests and their Fakes intoauction/tests.rs. The main file shrinks from 7,854 to 3,566 lines. Production function bodies, table definitions, reducer names, and arguments stay unchanged.What you verified
cargo check -p lyracore-module --testspassed with default features.cargo test -p lyracore-module --lib --features=debug_reducers:1565 passed; 0 failed.cargo clippy --workspace --all-targets --all-features -- -D warningspassed.auction_buyout,auction_cancel, andauction_expiry: all 6 tests passed against disposable local SpacetimeDB instances, including Transfer, expiry replay, and legacy Mail repair.build_scriptandpackage_api_lint: 7 and 37 tests passed.python3 scripts/check-gateway-bindings.py:All 1184 Gateway binding files are current.cargo fmt --all -- --checkandgit diff --checkpassed.The integration tests used the macOS linker option below for SpacetimeDB host symbols. They executed the real Wasm Module.
The Auction patch is unchanged after rebasing onto
ff2e6d6b. Independent adversarial review checked the original patch and its integration with the new base. The full Gateway suite also passed on rebased head6c23be8e, with 2,009 unit tests and 11 other tests. All nine CI checks passed on6c23be8e. Main then changed Gateway binding generation in #689. A second rebase onto5bb75ba4preserves all three Auction files byte for byte at7ae1a4fa. All nine CI checks passed at7ae1a4fa, including the new binding workflow and the complete durable suite. The independent reviewer confirmed compatibility with the pinned CLI and its recursive source fingerprints.What you did NOT verify
No real-client check or deployment to an existing Realm. Unrelated crate test suites and the complete durable suite were not run locally.
Risk
The main risk is losing a fixture reducer during the move. The durable tests and generated-binding comparison check that contract. Legacy Mail repair, Auction transaction rules, and Fake behavior are outside this change.
Model: GPT-6 Astra, high reasoning effort. Harness: Codex in T3 Code.