Skip to content

fix(taxi): keep target selection connected during flight - #681

Merged
Mathih13 merged 1 commit into
mainfrom
t3/issue-676-fix
Oct 11, 2026
Merged

Mathih13 merged 1 commit into
mainfrom
t3/issue-676-fix

Conversation

@Mathih13

@Mathih13 Mathih13 commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Selecting or clearing a target during a taxi flight ended the World Session. Argus recorded gw_set_target reducer failed: PLAYER_IN_TAXI_FLIGHT twice on October 10 at 22:19:48 and 22:21:13 UTC. The Standalone journal records the same reducer outcomes.

Allow target selection during flight. Keep Operator authorization, SessionActor ownership and the Transfer fence. CMaNGOS Classic permits this selection.

Refs #676. The logged cause is fixed here. Keep the issue open for its attended imported-route and reconnect check.

What you verified

  • The encrypted Headless Client regression uses the real Gateway, Coordinator and a private Module instance. Before the fix, selection reset the connection. After the fix, selection and clearing each receive PONG and update the durable target. Flight state and money stay unchanged.
  • The existing benilla_durable_ CI group includes the new regression.
  • Module unit tests: 1,564 passed. Gateway suite: 2,145 passed, 31 ignored. The new durable regression ran separately and passed.
  • Durable taxi Refusal contracts: 1 passed. Formatting and workspace Clippy pass.
  • Two read-only adversarial reviews, GPT-6 Astra for standards and Claude Opus 5.5 for the issue requirements, found no code blocker. Both retained the attended-check limit below.

What you did NOT verify

No production update or attended build-5875 client test. Complete imported-route travel, landing presentation and reconnect without another fare remain to be checked. The checkout reflog identifies 839643e2 before the incident; it does not prove the running artifact at that time.

The production change is limited to one Module Gateway Verb. No schema or packet layout changes.

Model: GPT-6 Astra. Harness: Codex in T3 Code.

@Mathih13
Mathih13 marked this pull request as ready for review October 11, 2026 16:43
@Mathih13
Mathih13 merged commit 0762fc8 into main Oct 11, 2026
9 checks passed
@Mathih13
Mathih13 deleted the t3/issue-676-fix branch October 11, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant