Repository navigation
fix(taxi): keep target selection connected during flight - #681
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting or clearing a target during a taxi flight ended the World Session. Argus recorded
gw_set_target reducer failed: PLAYER_IN_TAXI_FLIGHTtwice on October 10 at 22:19:48 and 22:21:13 UTC. The Standalone journal records the same reducer outcomes.Allow target selection during flight. Keep Operator authorization, SessionActor ownership and the Transfer fence. CMaNGOS Classic permits this selection.
Refs #676. The logged cause is fixed here. Keep the issue open for its attended imported-route and reconnect check.
What you verified
benilla_durable_CI group includes the new regression.What you did NOT verify
No production update or attended build-5875 client test. Complete imported-route travel, landing presentation and reconnect without another fare remain to be checked. The checkout reflog identifies
839643e2before the incident; it does not prove the running artifact at that time.The production change is limited to one Module Gateway Verb. No schema or packet layout changes.
Model: GPT-6 Astra. Harness: Codex in T3 Code.