Skip to content

fix(importer): keep quest definitions available across shards - #680

Merged
Mathih13 merged 3 commits into
mainfrom
fix/import-shared-quest-catalogue
Oct 11, 2026
Merged

Mathih13 merged 3 commits into
mainfrom
fix/import-shared-quest-catalogue

Conversation

@Mathih13

@Mathih13 Mathih13 commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

A Character can lose quest text and objectives after Transfer because each World Import Profile loads only quests from its local givers. Local scripted event requirements can also let an uncredited quest complete on another World Shard.

Build the quest catalogue and scripted event requirements from both starting profiles and the Instance Pool for every canonical profile. Keep creature and gameobject giver relations within the destination's World Import Scope. Retain summoned giver quests during partial reimports, and reapply the creature-ai Package Deltas when canonical quests reload their event requirements. Legacy map and box imports retain their selected scope.

What you verified

  • All 408 importer tests pass. Twelve client-data tests remain ignored.
  • Rust formatting and importer clippy pass with warnings treated as errors.
  • Tests compare shared definitions across all six canonical profiles, including Horde starting areas, while checking local giver relations.
  • Regressions reproduce missing summoned giver quests during partial reimports and premature quest completion after Transfer. Both pass with the repair.
  • Canonical quest reimports check the creature-ai Package Delta stage. The merged Hearthstone fix remains intact.

What you did not verify

No real world dump reimport or client Transfer was run. Full workspace and durable checks run in CI on the final revision.

Risk

Existing canonical imports need the quests and items families reimported on every World Shard and Instance Pool. Pass the enabled Package Inventory through --packages so Package Deltas are reapplied. This change adds no schema or protocol fields.

Model: GPT-6.1-sol, with independent GPT-6-astra reviews. Harness: Codex in T3 Code.

@Mathih13

Mathih13 commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor Author

Independent adversarial review found two gaps in the first revision: partial quest reimports dropped summoned giver quests, and destination-local event requirements allowed premature quest completion after Transfer.

49214610 fixes both and restores creature-ai Package Deltas after canonical quest reimports. 057b7633 corrects the import row count. The regressions cover shared completion rules, summoned giver relations, Package stage invocation, and Horde starting areas.

Both independent reviewers cleared the combined result. All 408 importer tests, formatting, and importer clippy pass locally. Twelve client-data tests remain ignored; no real world dump or client Transfer was tested. All nine CI checks passed on 057b763, including workspace tests and the durable suite. Merged as 1b2b7d31. Canonical imports now share quest definitions and completion rules while giver relations remain local.

@Mathih13
Mathih13 merged commit 1b2b7d3 into main Oct 11, 2026
9 checks passed
@Mathih13
Mathih13 deleted the fix/import-shared-quest-catalogue branch October 11, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant