Repository navigation
fix(importer): keep quest definitions available across shards - #680
Conversation
|
Independent adversarial review found two gaps in the first revision: partial quest reimports dropped summoned giver quests, and destination-local event requirements allowed premature quest completion after Transfer. 49214610 fixes both and restores Both independent reviewers cleared the combined result. All 408 importer tests, formatting, and importer clippy pass locally. Twelve client-data tests remain ignored; no real world dump or client Transfer was tested. All nine CI checks passed on 057b763, including workspace tests and the durable suite. Merged as 1b2b7d31. Canonical imports now share quest definitions and completion rules while giver relations remain local. |
A Character can lose quest text and objectives after Transfer because each World Import Profile loads only quests from its local givers. Local scripted event requirements can also let an uncredited quest complete on another World Shard.
Build the quest catalogue and scripted event requirements from both starting profiles and the Instance Pool for every canonical profile. Keep creature and gameobject giver relations within the destination's World Import Scope. Retain summoned giver quests during partial reimports, and reapply the
creature-aiPackage Deltas when canonical quests reload their event requirements. Legacy map and box imports retain their selected scope.What you verified
creature-aiPackage Delta stage. The merged Hearthstone fix remains intact.What you did not verify
No real world dump reimport or client Transfer was run. Full workspace and durable checks run in CI on the final revision.
Risk
Existing canonical imports need the
questsanditemsfamilies reimported on every World Shard and Instance Pool. Pass the enabled Package Inventory through--packagesso Package Deltas are reapplied. This change adds no schema or protocol fields.Model: GPT-6.1-sol, with independent GPT-6-astra reviews. Harness: Codex in T3 Code.