Repository navigation
fix(taxi): resolve mount creature entries to display IDs - #679
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flights used creature-template IDs as mount display IDs, so the client could show the wrong model. The importer now resolves each faction's TaxiNodes entry through the full creature-template dump and checks the selected display against CreatureDisplayInfo.
A zero faction entry uses the other faction's entry. A missing template or invalid display produces zero and a warning, so the Module refuses the flight. This follows the CMaNGOS Classic entry lookup and faction fallback. The catalogue uses the first nonzero template model; it does not randomize model or gender.
Standalone DBC imports now require
--taxi-mounts <dump.sql[.gz]>. The world import script passes its full dump, so mount resolution does not depend on spatially filtered creature templates. Existing catalogues need this import again. The refresh procedure and active-flight limit are documented. No schema change.Closes #677.
What you verified
1100,1101and passes with display IDs295,1147.cargo test -p lyracore-importer: 409 passed, 12 ignored.cargo clippy --workspace --all-targets --all-features -- -D warnings: passed.cargo fmt --all -- --check: passed.bash importer/scripts/import-world-sql-test.sh: 27 passed.bfb2748, including the durable suite and Official Packages.What you did not verify
No production catalogue was changed. The Mist's Edge flight could not be reproduced because its source and destination were not supplied. No real-client rendering check was run. The 12 ignored importer tests need external data.
Model: GPT-6-Astra with high reasoning effort. Harness: Codex in T3 Code.