Repository navigation
ci: shorten PR checks and stop superseded runs - #664
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checks usually take about 19 minutes. Uneven durable jobs, a five-minute Session expiry wait, superseded runs, and an unbounded dependency install delay contributor feedback.
This change cancels superseded PR runs, adds install and job timeouts, and distributes all Module test targets by recorded duration. The distribution includes time for each job's Gateway checks. New targets remain included with a default estimate. The Wasm build now uses the same features as the durable fixtures.
The Session test checks the five-minute production interval, then uses an Operator-only debug reducer to shorten its private schedule. It verifies two real scheduled cleanups and preserves renewed Sessions. The test takes 3.83 seconds locally with the Wasm already built. The production interval stays unchanged.
The auction regression also used an obsolete test path and passed with zero tests. Its corrected command checks that the exact test exists before it runs.
What you verified
cargo fmt --all -- --checkand workspace Clippy with all targets and features passed.debug_reducers: 1,569 passed.python3 -m unittest discover -s scripts/tests: 6 passed, including complete, unique selection of all 82 Module targets.actionlint1.7.12 passed.scripts/check-gateway-bindings.py: all 1,184 binding files match. SpacetimeDB schema extraction failed twice before the final check passed.Local Rust checks used
CARGO_PROFILE_DEV_DEBUG=0andCARGO_PROFILE_TEST_DEBUG=0. Rebased onto current main; its intervening change only added a skill.All nine GitHub checks passed on
95028a5a. The durable workflow completed in 16m18s. Its three jobs took 11m16s, 15m46s and 9m12s. This is one observed run, compared with the earlier PR median of 19m15s. CI ran the complete configured durable suite. The documentation push cancelled both jobs still running on the superseded revision, which confirms PR cancellation works.Two independent adversarial reviews found no blocking defects. The second review confirmed the corrected testing instructions. An earlier attempt failed during private fixture startup with connection refused; the same failure occurred before this PR. The final run passed without a fixture code change.
What you did NOT verify
Long-term timing and cold-cache behavior remain unmeasured. No production deployment or migration was performed.
Model: gpt-6-astra, high reasoning effort. Harness: Codex in T3 Code.