Repository navigation
fix(reputation): save and restore the watched faction - #654
Merged
Merged
Conversation
Mathih13
marked this pull request as ready for review
October 10, 2026 21:26
Mathih13
force-pushed
the
t3/research-fix-issue-650
branch
from
October 10, 2026 21:43
546865b to
a41777b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The watched reputation bar appeared without a selection. Character creation did not send the no-selection value, and the Gateway could not save a watched faction.
Save the signed reputation-list index in the Character row. Send -1 when no faction is selected, restore it on world entry, and send a private update after a successful selection or clear. Refuse out-of-range indices without changing reputation standing. Existing Characters default to -1, and old Transfer snapshots remain readable.
Closes #650.
Verification
The missing-field regression failed before the fix and passes with it. Local checks passed:
After rebasing onto
99a5feec, all 2,133 Gateway tests, all 1,569 Module unit tests, workspace clippy and the durable Headless Client reconnect test passed again. A read-only adversarial review confirmed that the conflict resolution preserves both trainer spell data and watched-faction state.Adversarial reviews used separate subagents. Standards: zero findings. Spec: zero implementation findings. Both reviewers checked the follow-up change to use the transfer-aware Character lookup.
Limits
The reporter confirmed that the affected display is the watched bar near the experience bar. I have not checked the result in a graphical build-5875 client or run a complete multi-shard Headless Client scenario. Durable map-change checks, Transfer tests and codec tests cover those component paths. Research and pinned protocol sources.
This appends a defaulted Character column and adds a Gateway Verb. Deploy the Module and Gateway together across the Realm. No production deployment is part of this PR.
Models: GPT-6-Astra and GPT-6.1-Sol. Harness: Codex in T3 Code.