Repository navigation
fix(importer): include Deeprun Tram objects in world profiles - #653
Merged
Merged
Conversation
Mathih13
marked this pull request as ready for review
October 10, 2026 21:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deeprun Tram objects were outside every canonical World Import Scope. The importer dropped their spawns before it selected the templates.
Include all of map 369 in the Eastern and single-Shard profiles. Keep the import script's expected maps consistent. The default World Shard serves this map under the documented topology. A regression test checks spawns and templates in all six profiles. The research note traces import, AOI and CREATE delivery and separates placed objects from tram movement and client scenery.
Refs #648. The issue stays open for the requested checks at both entrances with a real 1.12.1 client.
What you verified
cargo test -p lyracore-importer: 400 passed, 12 data-dependent tests ignored.cargo test -p lyracore-gateway: all enabled targets passed, including existing CREATE and AOI coverage. Durable tests remained ignored.cargo clippy -p lyracore-importer --all-targets --all-features -- -D warnings: passed.cargo fmt --all -- --check: passed.The SQL test fixture also needed the source lock file copied into its temporary checkout to reach its checks.
What you did NOT verify
No assembled-dump compatibility check, live import, deployed Shard contents, map-369 CREATE capture or real-client check. Existing installations need a content reimport. Tram-car movement and client scenery remain separate checks.
Made with GPT-6-Astra in the Codex harness through T3 Code. Research used GPT-6.1-Sol.