Skip to content

fix(importer): include Deeprun Tram objects in world profiles - #653

Merged
Mathih13 merged 2 commits into
mainfrom
t3/fix-issue-648
Oct 10, 2026
Merged

Mathih13 merged 2 commits into
mainfrom
t3/fix-issue-648

Conversation

@Mathih13

@Mathih13 Mathih13 commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

Deeprun Tram objects were outside every canonical World Import Scope. The importer dropped their spawns before it selected the templates.

Include all of map 369 in the Eastern and single-Shard profiles. Keep the import script's expected maps consistent. The default World Shard serves this map under the documented topology. A regression test checks spawns and templates in all six profiles. The research note traces import, AOI and CREATE delivery and separates placed objects from tram movement and client scenery.

Refs #648. The issue stays open for the requested checks at both entrances with a real 1.12.1 client.

What you verified

  • The new regression failed twice before the fix, with zero spawns instead of two.
  • cargo test -p lyracore-importer: 400 passed, 12 data-dependent tests ignored.
  • cargo test -p lyracore-gateway: all enabled targets passed, including existing CREATE and AOI coverage. Durable tests remained ignored.
  • cargo clippy -p lyracore-importer --all-targets --all-features -- -D warnings: passed.
  • cargo fmt --all -- --check: passed.
  • Import manifest smoke test and import script SQL test: passed, including all 26 SQL checks.
  • ShellCheck on both changed shell files: passed.
  • Two independent GPT-6-Astra adversarial reviews, standards and issue requirements: no actionable findings.

The SQL test fixture also needed the source lock file copied into its temporary checkout to reach its checks.

What you did NOT verify

No assembled-dump compatibility check, live import, deployed Shard contents, map-369 CREATE capture or real-client check. Existing installations need a content reimport. Tram-car movement and client scenery remain separate checks.

Made with GPT-6-Astra in the Codex harness through T3 Code. Research used GPT-6.1-Sol.

@Mathih13
Mathih13 marked this pull request as ready for review October 10, 2026 21:16
@Mathih13
Mathih13 merged commit 3f3ddd1 into main Oct 10, 2026
9 checks passed
@Mathih13
Mathih13 deleted the t3/fix-issue-648 branch October 11, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant