Repository navigation
fix(transfer): keep Kalimdor entry from ending the World Session - #652
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logging in to Kalimdor, or entering it, can end the World Session with
Transfer source has no Realm locator. Production logs show this failure for three Characters. The Character can exist on the default World Shard before its first Realm-core locator exists.Create the missing locator directly as pending in one transaction. A retry must name the same crossing. Bot Transfers still require their bound predecessor. During a pending Transfer, login checks for source Escrow before accepting the destination copy. The Gateway and Module change together; no schema or reducer arguments change.
What you verified
839643e2ca11fe62190b0d390549c915e6865aecto Argus. The production gate passed 4,500 tests, the build, and preflight. Published all four Databases with empty migration plans and ran repair on each. Restarted the Gateway; SpacetimeDB stayed running. Production status reports HEALTHY.c2fc3cf3, created a night elf, entered Shadowglen, received ping replies during a 90-second session, and logged out and back in. Screenshots confirm creation and world entry.lyracore-world-1to Northshire onlyracore, then back to Shadowglen. Benilla stayed connected and received ping replies after both crossings. Screenshots confirm both destinations. Each crossing left one Character record, a settled Realm-core locator, and no remaining Escrow or arrival fence. Locator revisions advanced from 2 to 3 to 4.What you did NOT verify
Model: GPT-6-Astra. Harness: Codex in T3 Code.