Skip to content

chore(cli): pin the CLI so packages disable runs Package Teardown - #631

Merged
Mathih13 merged 1 commit into
mainfrom
chore/cli-pin-package-teardown
Oct 7, 2026
Merged

Mathih13 merged 1 commit into
mainfrom
chore/cli-pin-package-teardown

Conversation

@Mathih13

@Mathih13 Mathih13 commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

packages disable on a Realm with bots left the next publish stuck, because the Package's tables still held rows. LyraCore#627 added Package Teardown to the Module, and lyracore-cli#64 made packages disable run it on every Shard before the folder moves. The pinned CLI here was still the old one, so ./lyracore packages disable did not run teardown yet, and the development CLI doc described behaviour the pin did not have.

This PR pins .lyracore-cli-rev to 091b502a1020e483df4322881bd808e0e6c958db, the lyracore-cli main merge commit of #64. I checked it the way docs/agents/cross-repo-cli.md asks. ./lyracore installed the pin, ./lyracore help --all lists packages disable NAME [--yes] with the teardown text, and the argument checks refuse a missing name, a second name and an unknown option.

Made by Claude Opus via Claude Code.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 24 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d195f418-f383-488d-803b-6dbfe9e11080
📥 Commits

Reviewing files that changed from the base of the PR and between f0078a9 and 2473ff8.

📒 Files selected for processing (1)
  • .lyracore-cli-rev
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Mathih13 commented Oct 7, 2026

Copy link
Copy Markdown
Contributor Author

Code review: two axes

Diff: .lyracore-cli-rev b225405 → 091b502. One file, one commit. No issue is linked. I used the PR body and docs/agents/cross-repo-cli.md as the spec.

Standards

No findings. A one-line pin bump gives CODING_STANDARDS.md and the smell baseline nothing to check. The conventional commit title matches the repo's other pin bumps.

Spec

  • Pin reachable (cross-repo-cli.md step 4): met. 091b502 is the current refs/heads/main of lyracore-cli and the merge commit of lyracore-cli#64.
  • No unexpected CLI changes: met. b225405..091b502 contains lyracore-cli#63's merge (cf83e48), whose tree is the same as the old pin's tree, plus Gateway has no SIGTERM handler, so a restart hard-RSTs every session with no drain or logout #64's two commits (41929a7 run teardown before disable, e9eec49 plainer notice). Nothing else comes along with the bump.
  • Docs match the pin: met. docs/development-cli.md:99 and :311-315 already describe packages disable running Package Teardown. This pin is what makes that true.
  • Step 5 (./lyracore --help plus argument checks): the PR body says these were run. I did not run them again.
  • Note, low priority: CI was still running when I posted this. fmt, test, clippy and durable (0-2) were in progress, and build, wasm and deploy-scripts had passed. None of these jobs exercise the CLI pin, so they cannot confirm the new behaviour.

Summary: Standards 0 findings. Spec 0 blocking findings and 1 low note (CI was still running). Ready to merge once CI is green.


Generated by Claude Code

@Mathih13
Mathih13 merged commit 0be9bb9 into main Oct 7, 2026
10 checks passed
@Mathih13
Mathih13 deleted the chore/cli-pin-package-teardown branch October 7, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant