Skip to content

fix(loot): retry failed settlements while results remain - #474

Merged
Mathih13 merged 2 commits into
mainfrom
fix/loot-settlement-retry-84-sept8
Sep 8, 2026
Merged

Mathih13 merged 2 commits into
mainfrom
fix/loot-settlement-retry-84-sept8

Conversation

@Mathih13

@Mathih13 Mathih13 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

When one Shard cannot accept a resolved Loot Roll, the Gateway advances its completion marker and skips the result on later ticks. Keep the marker until every settlement succeeds, while continuing to settle healthy Shards.

Verified the failure on the unchanged Gateway before fixing it. The recovery regression proves that the failed Shard receives the result on the next successful tick and that completed results stop replaying. The full Gateway suite passed, 1,444 tests with 7 private integration tests ignored. Formatting and Gateway clippy with all targets and features passed.

Retries remain limited to the lifetime of the Realm-core result event, which is one second. Recovery beyond expiry needs an immutable settlement identity: a retained corpse GUID and slot could otherwise refer to a later respawn. The original three-Shard and bot-party acceptance remains open. Refs #84.

Implemented with GPT-6 in the Codex harness.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 56f4a0ce-67d7-44d8-9c0b-a0439e3cd58a

📥 Commits

Reviewing files that changed from the base of the PR and between c6003e5 and 2a11e7c.

📒 Files selected for processing (2)
  • gateway/src/world/loot.rs
  • gateway/src/world/loot_tests.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Mathih13

Mathih13 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

Independent review by GPT-5.6 Sol in Codex is complete at 2a11e7c with no remaining findings. The requested wording correction now states the actual settlement guards and their identity limit. The focused regression proves retry and completion-marker behavior; it does not establish the cause of the original three-Shard incident.

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

@Mathih13 I will complete a full review of #474.

⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 58 minutes.

@Mathih13
Mathih13 merged commit e41d5f8 into main Sep 8, 2026
7 checks passed
@Mathih13
Mathih13 deleted the fix/loot-settlement-retry-84-sept8 branch October 11, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant