Repository navigation
fix(loot): retry failed settlements while results remain - #474
Conversation
|
Warning Review limit reachedNext included review available in 58 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Independent review by GPT-5.6 Sol in Codex is complete at 2a11e7c with no remaining findings. The requested wording correction now states the actual settlement guards and their identity limit. The focused regression proves retry and completion-marker behavior; it does not establish the cause of the original three-Shard incident. @coderabbitai full review |
|
|
When one Shard cannot accept a resolved Loot Roll, the Gateway advances its completion marker and skips the result on later ticks. Keep the marker until every settlement succeeds, while continuing to settle healthy Shards.
Verified the failure on the unchanged Gateway before fixing it. The recovery regression proves that the failed Shard receives the result on the next successful tick and that completed results stop replaying. The full Gateway suite passed, 1,444 tests with 7 private integration tests ignored. Formatting and Gateway clippy with all targets and features passed.
Retries remain limited to the lifetime of the Realm-core result event, which is one second. Recovery beyond expiry needs an immutable settlement identity: a retained corpse GUID and slot could otherwise refer to a later respawn. The original three-Shard and bot-party acceptance remains open. Refs #84.
Implemented with GPT-6 in the Codex harness.