Skip to content

test(dive): pin the drowning acceptance adapter - #454

Merged
Mathih13 merged 1 commit into
mainfrom
fix/wire-dive-adapter-pin
Sep 7, 2026
Merged

Mathih13 merged 1 commit into
mainfrom
fix/wire-dive-adapter-pin

Conversation

@Mathih13

@Mathih13 Mathih13 commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

LyraCore’s pinned Headless Client release has no maintained dive flow for the Breath timer, drowning damage, and timer stop after surfacing. Pin wire-harness v0.1.0-alpha.8 to add the reviewed protocol scenario and LyraCore adapter.

The release verifies the timer and damage packets against the own Character’s observed health, waits through the advertised Breath window, and checks durable damage and surface position. The adapter verifies imported liquid before it changes a clearly named disposable Character.

Refs #142 and #12. Coordinate selection, the Operator Realm run, head-height calibration, and stock-client acceptance remain pending.

Validation:

  • Fresh-clone tag verification resolved v0.1.0-alpha.8 to 538423176c4b2a3dd1ba8eae1cc1ab1a1cc877cf
  • .wire-harness-rev tag and SHA match the remote tag
  • ./lyracore --help
  • ./lyracore help --all exposes lyracore dev smoke
  • bash -n lyracore and all scripts/*.sh
  • git diff --check
  • Upstream wire-harness PR Rogue Distract (effect 69) still falls through to a scripted no-op #10 passed 75 tests, strict clippy, release builds, offline adapter checks, ShellCheck, and Ubuntu/macOS/coverage CI

Implemented by GPT-5.6 Sol through Codex in T3 Code.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 9 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 7dfba4b5-0b84-4a36-b76a-14b4d5b25214

📥 Commits

Reviewing files that changed from the base of the PR and between e26ffff and 4bf3a52.

📒 Files selected for processing (1)
  • .wire-harness-rev

Comment @coderabbitai help to get the list of available commands.

@Mathih13
Mathih13 merged commit 32aa004 into main Sep 7, 2026
7 checks passed
@Mathih13
Mathih13 deleted the fix/wire-dive-adapter-pin branch October 11, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant