Skip to content

test(bank): pin the bank acceptance adapter - #453

Merged
Mathih13 merged 1 commit into
mainfrom
fix/wire-bank-adapter-pin
Sep 7, 2026
Merged

Mathih13 merged 1 commit into
mainfrom
fix/wire-bank-adapter-pin

Conversation

@Mathih13

@Mathih13 Mathih13 commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

LyraCore has no maintained bank acceptance adapter in its pinned Headless Client release. Pin alpha.7 to add activation, deposit, relog persistence, withdrawal and bank bag purchase checks.

Refs #137. Live execution and stock-client window acceptance remain with the Operator.

Verified the tag in a fresh clone at e812f530e807723dbdd83433e649b8bb0c1eb5ec, wrapper help and shell syntax. Upstream PR #9 passed parent review, 69 tests, strict clippy, release builds, offline shell checks and Ubuntu/macOS/coverage CI.

Implemented by GPT-5.6 Sol and integrated by GPT-6 through Codex in the T3 Code harness.

Summary by CodeRabbit

  • Chores
    • Updated the pinned wire-harness release to v0.1.0-alpha.7 with its verified commit reference.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 49ba43cf-21b1-422d-84ec-31e7cee9fcec

📥 Commits

Reviewing files that changed from the base of the PR and between 6ccfe68 and 04e5ac5.

📒 Files selected for processing (1)
  • .wire-harness-rev

Included review availability: Your plan provides up to 10 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The change updates the pinned wire-harness release from v0.1.0-alpha.6 to v0.1.0-alpha.7 and replaces its commit SHA.

Changes

Wire-harness revision update

Layer / File(s) Summary
Revision pin
.wire-harness-rev
The pinned wire-harness tag and commit SHA now reference v0.1.0-alpha.7 and e812f530....

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 04e5a

This updates the wire-harness acceptance adapter pin to alpha.7 while retaining tag-and-SHA verification. No current merge-blocking behavior, integrity, or deployment risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: pinning the bank acceptance adapter for bank tests. It is concise and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/wire-bank-adapter-pin

Comment @coderabbitai help to get the list of available commands.

@Mathih13
Mathih13 merged commit e26ffff into main Sep 7, 2026
7 checks passed
@Mathih13
Mathih13 deleted the fix/wire-bank-adapter-pin branch October 11, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant