Repository navigation
chore(cli): pin effective service verification - #452
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe repository updates the pinned LyraCore CLI revision from ChangesCLI revision update
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The update selects a CLI version that improves systemd ExecStart reconciliation for continued lines and drop-ins. The pinned revision meets the existing loader contract, with no current merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
The pinned CLI could miss a conflicting service command split across continued unit lines and could certify an
ExecStartchanged by a systemd drop-in.This pin adopts LyraCoreProject/lyracore-cli#57. The CLI now parses logical systemd lines and compares the typed effective start command, including executable path and argument boundaries. A mismatch reports the applicable drop-ins.
Closes #340.
Closes #341.
Validation:
ad2aa067bf5c9bf47c3c4034aaa3897c1eb6f502is the current reachable CLImain./lyracore --help./lyracore service reconcile --forcerefused the extra argument with exit 2 before service logicgit diff --check origin/mainImplemented by GPT-5.6 Sol through Codex in the T3 Code harness.
Summary by CodeRabbit