Skip to content

chore(cli): pin effective service verification - #452

Merged
Mathih13 merged 1 commit into
mainfrom
fix/service-contract-cli-pin
Sep 7, 2026
Merged

Mathih13 merged 1 commit into
mainfrom
fix/service-contract-cli-pin

Conversation

@Mathih13

@Mathih13 Mathih13 commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

The pinned CLI could miss a conflicting service command split across continued unit lines and could certify an ExecStart changed by a systemd drop-in.

This pin adopts LyraCoreProject/lyracore-cli#57. The CLI now parses logical systemd lines and compares the typed effective start command, including executable path and argument boundaries. A mismatch reports the applicable drop-ins.

Closes #340.
Closes #341.

Validation:

  • Confirmed ad2aa067bf5c9bf47c3c4034aaa3897c1eb6f502 is the current reachable CLI main
  • ./lyracore --help
  • ./lyracore service reconcile --force refused the extra argument with exit 2 before service logic
  • git diff --check origin/main

Implemented by GPT-5.6 Sol through Codex in the T3 Code harness.

Summary by CodeRabbit

  • Chores
    • Updated the pinned revision used by the CLI.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 34c09747-3741-44d0-8807-192985ce8d32

📥 Commits

Reviewing files that changed from the base of the PR and between 6ccfe68 and 186556e.

📒 Files selected for processing (1)
  • .lyracore-cli-rev

Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The repository updates the pinned LyraCore CLI revision from def8492a6b135ffc4afe69a1100e0f9c08519735 to ad2aa067bf5c9bf47c3c4034aaa3897c1eb6f502.

Changes

CLI revision update

Layer / File(s) Summary
Update CLI revision pin
.lyracore-cli-rev
The pinned LyraCore CLI revision changes to ad2aa067bf5c9bf47c3c4034aaa3897c1eb6f502.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 18655

The update selects a CLI version that improves systemd ExecStart reconciliation for continued lines and drop-ins. The pinned revision meets the existing loader contract, with no current merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the primary change: pinning the CLI revision for effective service verification.
Linked Issues check ✅ Passed The pinned CLI revision addresses both linked issues [#340] and [#341] by adding effective ExecStart and drop-in verification, using tracked unit values, and parsing continued systemd lines.
Out of Scope Changes check ✅ Passed The changes are limited to updating the CLI revision pin. No unrelated code or configuration changes are present.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/service-contract-cli-pin

Comment @coderabbitai help to get the list of available commands.

@Mathih13
Mathih13 merged commit a76684b into main Sep 7, 2026
7 checks passed
@Mathih13
Mathih13 deleted the fix/service-contract-cli-pin branch October 11, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

service reconcile: unit parser ignores systemd line continuations service reconcile: verification misses drop-in overrides and ExecStart drift

1 participant