Repository navigation
fix(bench): pin dead-client reporting release - #449
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change updates the pinned wire-harness release from ChangesWire-harness update
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates the benchmark harness to alpha.6 for dead-client reporting while preserving a verified revision pin. No merge-blocking current-head risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Mathih13
marked this pull request as draft
September 7, 2026 13:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raid benchmark reports did not show how many connected clients were dead. Use wire-harness alpha.6, which reports dead and death-unknown counts at each measured window close and applies zero defaults to sparse Character CREATE snapshots. The additive ramp stays intact.
Upstream PRs #7 and #8 passed review, Linux and macOS CI, coverage, strict clippy and release builds. All 65 local tests passed. A fresh clone of the release tag resolves to the pinned merge commit. The local shim passes syntax and help checks.
Closes #75. This delivers the issue's reporting half; automatic recovery remains separate work.
Made by GPT-6 through Codex in T3 Code. The upstream implementation was made by GPT-5.6 Sol through Codex in T3 Code.
Summary by CodeRabbit