Skip to content

fix(bench): pin dead-client reporting release - #449

Merged
Mathih13 merged 2 commits into
mainfrom
fix/wire-benchmark-release-pin
Sep 7, 2026
Merged

Mathih13 merged 2 commits into
mainfrom
fix/wire-benchmark-release-pin

Conversation

@Mathih13

@Mathih13 Mathih13 commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

Raid benchmark reports did not show how many connected clients were dead. Use wire-harness alpha.6, which reports dead and death-unknown counts at each measured window close and applies zero defaults to sparse Character CREATE snapshots. The additive ramp stays intact.

Upstream PRs #7 and #8 passed review, Linux and macOS CI, coverage, strict clippy and release builds. All 65 local tests passed. A fresh clone of the release tag resolves to the pinned merge commit. The local shim passes syntax and help checks.

Closes #75. This delivers the issue's reporting half; automatic recovery remains separate work.

Made by GPT-6 through Codex in T3 Code. The upstream implementation was made by GPT-5.6 Sol through Codex in T3 Code.

Summary by CodeRabbit

  • Chores
    • Updated the wire-harness release to the latest alpha version.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 5f2372ac-2bbf-4934-8a3b-c9607965bdc5

📥 Commits

Reviewing files that changed from the base of the PR and between 2235dce and 00f64bb.

📒 Files selected for processing (1)
  • .wire-harness-rev

Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The change updates the pinned wire-harness release from v0.1.0-alpha.5 to v0.1.0-alpha.6 and replaces the verified commit SHA.

Changes

Wire-harness update

Layer / File(s) Summary
Update revision pin
.wire-harness-rev
The pin now references v0.1.0-alpha.6 at commit 78f191f5463d6834041801b0d6d9079427907ec9.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 00f64

This updates the benchmark harness to alpha.6 for dead-client reporting while preserving a verified revision pin. No merge-blocking current-head risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the benchmark change: pinning the release that provides dead-client reporting.
Linked Issues check ✅ Passed The pinned alpha.6 release delivers the reporting portion of issue #75 by reporting dead and death-unknown clients while preserving additive stage semantics. Recovery remains correctly out of scope.
Out of Scope Changes check ✅ Passed The pull request changes only the wire-harness revision and verified commit SHA. This change directly supports the linked issue and introduces no unrelated code changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/wire-benchmark-release-pin

Comment @coderabbitai help to get the list of available commands.

@Mathih13
Mathih13 marked this pull request as draft September 7, 2026 13:58
@Mathih13
Mathih13 marked this pull request as ready for review September 7, 2026 14:04
@Mathih13
Mathih13 merged commit e6194ef into main Sep 7, 2026
7 checks passed
@Mathih13
Mathih13 deleted the fix/wire-benchmark-release-pin branch October 11, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bench raid mode: clients killed by the boss never revive, and the report does not say how many are dead

1 participant