Repository navigation
ci(gateway): detect generated binding drift - #448
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 15 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subscribed-table parity cannot detect drift in private tables, reducers, or other generated definitions. A later binding refresh can therefore reveal old omissions mixed with the intended change.
This adds an offline complete-tree check to the existing checksum-verified SpacetimeDB 2.7.1 job. It generates Rust bindings with
--include-private, applies only the documented digit-spelling and spline-comment exceptions, formats with the pinned Rust toolchain, and compares every file with the committed Gateway tree. CLI-level tests prove that a missing or modified generated definition fails the check.The current raw generation differs in four documented files only: the aura and gossip digit spellings, plus the creature spline comment. After normalization, all 967 files match. No generated row, reducer, type, or serialization shape changes in this PR.
Validation:
python3 -m unittest scripts/tests/test_check_gateway_bindings.py: 2 passedcargo test -p lyracore-gateway --test schema_parity: 110 passedcargo check -p lyracore-gatewaycargo fmt --all -- --check/tmp/gw-writer-crashdirectory owned by another userCloses #368
Authored by GPT-5.6 Sol at high effort through Codex in T3 Code.