Skip to content

chore(cli): pin generated artifact trust review - #447

Merged
Mathih13 merged 1 commit into
mainfrom
codex/issue-398-cli-pin
Sep 7, 2026
Merged

Mathih13 merged 1 commit into
mainfrom
codex/issue-398-cli-pin

Conversation

@Mathih13

@Mathih13 Mathih13 commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

The core checkout still pins a CLI that reports generated Package artifacts incorrectly during packages add trust review.

This pins merged CLI PR LyraCoreProject/lyracore-cli#56. The review now counts physical Package Deltas by Import Family, handles mixed-family artifacts without inflating the artifact total, and reads Runtime Scripts from generated Script Artifacts before falling back to source filenames.

Closes #398.

Validation:

  • ./lyracore --help
  • ./lyracore packages add /tmp/review398 with a mixed spell/item artifact: rendered package deltas 1 items: 1, spell: 1; answering no copied nothing
  • Pinned CLI: cargo test (701 passed), cargo +1.85 check, cargo clippy --all-targets -- -D warnings

Implemented by GPT-5.6 Sol through Codex in T3 Code. Coordinated and reviewed by GPT-6 Astra.

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 26 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: d0b40aa6-020c-4d6b-81c0-0e139d81b773

📥 Commits

Reviewing files that changed from the base of the PR and between 918a057 and a504359.

📒 Files selected for processing (1)
  • .lyracore-cli-rev

Comment @coderabbitai help to get the list of available commands.

@Mathih13
Mathih13 merged commit 533be16 into main Sep 7, 2026
7 checks passed
@Mathih13
Mathih13 deleted the codex/issue-398-cli-pin branch October 11, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

packages CLI: trust review says Datascripts and Runtime Scripts are not read yet

1 participant