Repository navigation
chore(cli): pin generated artifact trust review - #447
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 26 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core checkout still pins a CLI that reports generated Package artifacts incorrectly during
packages addtrust review.This pins merged CLI PR LyraCoreProject/lyracore-cli#56. The review now counts physical Package Deltas by Import Family, handles mixed-family artifacts without inflating the artifact total, and reads Runtime Scripts from generated Script Artifacts before falling back to source filenames.
Closes #398.
Validation:
./lyracore --help./lyracore packages add /tmp/review398with a mixed spell/item artifact: renderedpackage deltas 1 items: 1, spell: 1; answeringnocopied nothingcargo test(701 passed),cargo +1.85 check,cargo clippy --all-targets -- -D warningsImplemented by GPT-5.6 Sol through Codex in T3 Code. Coordinated and reviewed by GPT-6 Astra.