Repository navigation
fix(package-delta): protect fixture creatures from cast claims - #434
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe change reuses creature-entry validation for creature casts and creature spells. Claims now reject zero, oversized, and fixture-reserved creature entries. Tests cover fixture rejection for both cast tables. ChangesCreature cast validation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Creature cast and spell claims now reject reserved fixture creature entries while preserving valid imported entries and partial spell updates. The affected validation paths and rejection behavior are covered, with no remaining merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
784b67f to
1b120cc
Compare
Package Delta parsing accepted cast claims that named the Module fixture creature cluster. A partial
game_creature_spellupdate could also hide its fixture target in the existing row, or replace that target while changing the fixture-owned row.The parser now applies the existing creature-entry fixture policy at each table's artifact boundary.
game_creature_castchecks itscreature_entrykey.game_creature_spellkeeps its surrogateidpolicy and checks an explicitcreature_entryfield.The casts reference Gate also checks the existing and final creature targets after it resolves the row on the Shard. This closes partial-update and retarget-away paths without requiring
creature_entryon every update. Imported creature entries remain accepted.Closes #404
Verification:
cargo test -p lyracore-package-deltacargo test -p lyracore-modulecargo clippy -p lyracore-package-delta --all-targets -- -D warningsrustfmt --edition 2021 --checkon the four changed files./lyracore preflightImplemented by GPT-5.6 Sol via Codex.