Repository navigation
perf(creatures): find fear auras through an index - #428
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change adds a ChangesFear aura lookup
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to Fear movement now selects control/fear aura candidates through a composite index rather than scanning all auras, preserving the existing resolution behavior while reducing per-tick work. No current merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Fear movement scanned every aura on each creature tick to find the few control auras that cause fear. A composite index on the existing effect-kind and parameter columns now selects those candidates directly. Scope checks, deduplication and the source-caster tie break keep their existing behavior.
This addresses the aura-scan finding in the performance and correctness report.
Verified with 1,470 Module tests in an isolated build, the focused cycle suite, a Wasm check and offline preflight. A plain publish from the baseline to this change on a private in-memory Standalone created only the new index and preserved a distinctive existing row. No row shape, generated binding or backfill changes are needed. This removes unrelated aura reads; it is not a measured realm capacity result.
Implemented by GPT-5.6 Sol through Codex, reviewed by GPT-6 through Codex.
Summary by CodeRabbit