Skip to content

Core still names the dungeons Package, so its name tripwire cannot cover it yet #633

Open

Description

@Mathih13

Expected. Core names no official Package in its non-test source. The package_name_tripwire in module/src/tripwires.rs enforces this per Package, by matching a case-insensitive substring of the Package's name against every line.

Actual (at 87109e3c). OFFICIAL_PACKAGES still lists only "playerbots" (module/src/tripwires.rs#L2238), the Package #632 added coverage for. dungeons is not listed, because Core still names it and its Deadmines content directly. git grep -n -i -E 'deadmines|dungeons' -- module gateway crates importer ':!**/tests/**' ':!**/*_tests.rs' ':!**/tests.rs' finds 141 matching lines today, across about 25 files in module, gateway, crates and importer. The tripwire's match is a plain substring (line.contains(name), module/src/tripwires.rs#L2248-L2255), so adding "dungeons" today would also fail on every ordinary use of the English word, for example crates/lyracore-shared/src/instance.rs's "Which maps are DUNGEONS" doc comment.

How it shows. Nothing breaks yet; the gap is that OFFICIAL_PACKAGES cannot grow to include dungeons without first separating "this line names the Package" from "this line names the vanilla dungeon". Until then the tripwire protects only playerbots.

Fix direction. Work through the 141 lines deciding, per the issue's own split: a mention of the vanilla map or its bosses (Deadmines, Rhahk'Zor, Sneed, Mr. Smite, Gilnid) names game content and stays; a mention of the dungeons Package, its folder path, or its encounter hooks gets rewritten to drop the name (for example packages/dungeons/ becomes a generic "the encounter-owning Package" in comments) or is left to the test-only exemption. Either rewrite the ordinary-English-word lines the plain substring match would otherwise flag, or narrow the match for this Package to a stricter form such as packages/dungeons or pkg_dungeons_. Then add "dungeons" to OFFICIAL_PACKAGES and confirm cargo test -p lyracore-module --lib package_name_tripwire and a no-Package Core build both pass.

Activity

  1. added
    ready-for-agentComplete enough to build from the issue alone, by a person or their agent
    P2normal
    enhancementNew feature or request
    on Oct 7, 2026
  2. changed the title [-]Core names the dungeons Package and Deadmines[/-] [+]Core still names the dungeons Package, so its name tripwire cannot cover it yet[/+] on Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2normalenhancementNew feature or requestready-for-agentComplete enough to build from the issue alone, by a person or their agent

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions