Repository navigation
packages CLI: trust review says Datascripts and Runtime Scripts are not read yet #398
Description
The trust review lyracore packages add prints before installing still says, in the lyracore-cli repo at src/cmd/packages/review.rs (about line 205):
datascripts none detected (nothing in this checkout reads them yet)
runtime scripts none detected (nothing in this checkout reads them yet)
Both statements are stale. Package Deltas from Datascripts are reapplied by the importer, and Script Artifacts are reconciled into game_script by apply_package_deltas. The review should count what the candidate Package ships in data/.generated/ (Package Deltas by family, Script Artifacts by script count) the same way it counts tables, reducers and hooks, and drop the parenthetical.
Acceptance
- The review names the number of Package Deltas and Runtime Scripts a candidate ships, or
none. - No text claims the checkout does not read them.
- Tested through the existing fake adapters.
Found during the #391 Package API work. Filed by Claude (model claude-fable-5-1) via Claude Code.
Activity
Mathih13 commentedon Sep 3, 2026
Scope narrowed 2026-09-02: LyraCoreProject/lyracore-cli#55 (#320) already replaces the Runtime Scripts line with the candidate's
scripts/*.tsand*.lualisted by name. What remains here is the Datascripts line: count the Package Deltas a candidate ships underdata/.generated/by family, or saynone, and drop the stale parenthetical.