You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Confirm on a real client that the Defias Cannon needs its gunpowder #367
Expected (1.12.1). The Defias Cannon in the Deadmines (gameobject template 16398, lock 83) fires only for a player who carries Defias Gunpowder. Without it, use fails and the Iron Clad Door stays shut.
Actual (at 87109e3c). The code is fixed. Since #440, a locked GOOBER, DOOR or BUTTON runs the lock Gate before quest credit or a Package hook (gameobject.rs#L867-L868). A Standalone test proves the refusal and the success with equivalent lock data. Nobody has used the imported cannon from a real client.
How to check. On a Realm with imported Deadmines data and the dungeons Package, use the cannon without the gunpowder: it must refuse. Use it with the gunpowder: it fires and the door opens.
Done when. Both results are recorded here, with the client build and the commit.
PR #440 is merged. Locked GOOBER use now applies the existing lock Gate before quest credit or Package hooks. The private Standalone regression proves a Refusal leaves quest progress, hook XP, GOOBER state and unlock state unchanged, then proves success through the existing item opener. A lockless GOOBER still works.
All seven check contexts passed and there are no unresolved review threads. CodeRabbit was rate limited for the final revision; the coordinating agent independently reviewed the exact diff.
The remaining acceptance is use of the imported Defias Cannon with a real 1.12 client. The automated test uses equivalent reserved lock data, so this issue stays open for that check.
changed the title [-]gameobject: GOOBER use skips its lock, so the Defias Cannon fires without gunpowder[/-][+]Confirm on a real client that the Defias Cannon needs its gunpowder[/+]on Oct 8, 2026
Activity
Mathih13 commentedon Sep 7, 2026
PR #440 is merged. Locked GOOBER use now applies the existing lock Gate before quest credit or Package hooks. The private Standalone regression proves a Refusal leaves quest progress, hook XP, GOOBER state and unlock state unchanged, then proves success through the existing item opener. A lockless GOOBER still works.
All seven check contexts passed and there are no unresolved review threads. CodeRabbit was rate limited for the final revision; the coordinating agent independently reviewed the exact diff.
The remaining acceptance is use of the imported Defias Cannon with a real 1.12 client. The automated test uses equivalent reserved lock data, so this issue stays open for that check.
Verification: #440 (comment)
[-]gameobject: GOOBER use skips its lock, so the Defias Cannon fires without gunpowder[/-][+]Confirm on a real client that the Defias Cannon needs its gunpowder[/+]