Skip to content

clippy gate is red on main: ~68 lints across the workspace #353

Closed

Description

@Mathih13

This was generated by AI during triage.

Follow-up from #345, whose specific approx_constant report no longer reproduces (closed with evidence). But cargo clippy --workspace --all-targets --all-features -- -D warnings on main (7120ff4) still fails with roughly 68 errors spread across the workspace: too_many_arguments, needless_return, excessive_precision in Package spawn-point data, digit-grouping, and the unused import: $path as $verb warning at module/src/actor.rs:77 that #345 also mentioned.

Impact: no repo-wide clippy gate can be enforced in CI while main is red; agents and humans fall back to "zero new warnings in touched files", which lets debt persist. Worth one sweep PR (mechanical fixes, no behavior changes) or a small series per crate.

Activity

  1. Mathih13 commented on Aug 28, 2026

    @Mathih13
    ContributorAuthor

    Recount after #363, 2026-08-28: still roughly 68 findings on main. The excessive_precision subset in Package spawn-point data went away with the retired dungeon packages, so the sweep is slightly smaller than first scoped.

  2. Mathih13 commented on Sep 7, 2026

    @Mathih13
    ContributorAuthor

    This was generated by AI during triage.

    PR #419 is merged. The blocking clippy job runs cargo clippy --workspace --all-targets --all-features -- -D warnings and passed on main b4c17c481f66784fd24677f583e0368fc3ac8c95. Formatting and the other Rust checks passed too.

    Evidence: https://github.com/LyraCoreProject/LyraCore/actions/runs/34103823042 and https://github.com/LyraCoreProject/LyraCore/blob/b4c17c481f66784fd24677f583e0368fc3ac8c95/.github/workflows/rust.yml .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions