Package Deltas: support dump-backed catalogue Import Families #311

Activity

1. Mathih13

   added

   enhancementNew feature or requestNew feature or request

   P3someday / nice-to-havesomeday / nice-to-have

   ready-for-agentComplete enough to build from the issue alone, by a person or their agentComplete enough to build from the issue alone, by a person or their agent

   on Aug 24, 2026
2. Mathih13

   added a parent issue on Aug 24, 2026

   • packages data layer: datascript delta pipeline (replay, conflicts, validation) #95
3. Mathih13

   marked this as blocked on Aug 24, 2026

   • Package Deltas: apply and replay spell claims after base import #309
4. Mathih13

   added 2 commits that reference this issue on Aug 28, 2026

   feat(package-delta): add the quests and loot Import Families

   ...

   577aa99

   feat(package-delta): add the quests and loot Import Families

   ...

   f42b231
5. Mathih13 commented on Aug 31, 2026

   

   Mathih13

   on Aug 31, 2026

   ContributorAuthor

   More actions

   This was generated by AI during triage.

   Batch relevance check, 2026-08-31. Partially shipped:

   • Landed on main: the family-generic core (PR refactor(package-delta): make adding an Import Family a fill-in #355), items (PR feat(package-delta): add the items Import Family #357), quests and loot (PR feat(package-delta): add the quests and loot Import Families #359), with cross-table reference checks tested at module/tests/package_delta_references.rs.
   • Remaining: the gossip, trainers, casts, globals, and spellmeta families. None has Table variants in crates/lyracore-package-delta/src/schema.rs, a ClaimFamily implementation, or an entry in PACKAGE_DELTA_DUMP_FAMILIES (importer/src/main.rs, currently items/loot/quests only). The dump ETL already imports all of them, so the work is the claim layer only.
   • The branch feat/311-package-delta-gossip-trainers-casts-globals is a stale placeholder (bit-identical to the quests-loot tip), not work in progress.

   Spec and implementation for the remaining families are in progress in this session; per-table claim policy (partial update / insert / neither) will be recorded per the issue's acceptance criteria.
6. Mathih13 commented on Sep 3, 2026

   

   Mathih13

   on Sep 3, 2026

   ContributorAuthor

   More actions

   Per-table claim policy for the three families in #401.

   Family	Table	Policy	Why
   gossip	game_gossip_menu	neither (update only)	Key is a creature template entry. No Package may invent one.
   gossip	game_gossip_menu_profile	insert + partial update	menu_id is its own identifier space.
   gossip	game_gossip_menu_profile_option	insert + partial update	Surrogate row_id.
   gossip	game_gossip_option	insert + partial update	Surrogate row_id; the creature is a claimed column, not the key.
   gossip	game_npc_text	insert + partial update	text_id is its own identifier space.
   gossip	game_npc_text_slot	insert + partial update	Surrogate id.
   globals	game_class_level_stats	neither (update only)	Key names a class and a level the client fixes.
   globals	game_level_stats	neither (update only)	Key names a race, class and level the client fixes.
   globals	game_start_position	neither (update only)	Key names a race and a class the client fixes.
   globals	game_graveyard_zone	insert + partial update	Surrogate row_id.
   globals	game_areatrigger_teleport	neither (update only)	Key is an AreaTrigger.dbc trigger id.
   globals	game_createinfo_spell	insert + partial update	Surrogate id.
   globals	game_createinfo_action	insert + partial update	Surrogate row_id.
   globals	game_start_item	out of scope	Two importer passes own it (--dump globals from 1,000,000 up, --dbc CharStartOutfit below). Only the first has a Package Delta stage, so a claim on a --dbc-owned row would be reverted with nothing to reapply it.
   spellmeta	game_spell_chain	insert + partial update	Key IS a spell identifier, so an insert must name a Package spell, not a spellmeta identifier.
   spellmeta	game_spell_learn	insert + partial update	Surrogate id.
   spellmeta	game_spell_proc_event	insert + partial update	Same spell-identifier policy as game_spell_chain.

   Package Identifier Ranges: gossip 12,000,000-12,999,999 (all five insertable gossip tables), globals 13,000,000-13,999,999 (the three surrogate-key tables), spellmeta 14,000,000-14,999,999 (game_spell_learn alone).

   With #401 every dump-backed non-spatial family named in this issue has a claim schema, a ClaimFamily, and an entry in PACKAGE_DELTA_DUMP_FAMILIES.
7. Mathih13 commented on Sep 3, 2026

   

   Mathih13

   on Sep 3, 2026

   ContributorAuthor

   More actions

   PR filed 2026-09-02: #401 adds the gossip, globals and spellmeta claim families with per-table policy (see the table above), reference checks, live-DB coverage in module/tests/package_delta_references.rs, and three glossary entries. With it every dump-backed non-spatial family in the issue has a claim layer; game_start_item stays out because its identifiers below 1,000,000 belong to the --dbc CharStartOutfit pass. Orchestrated by Claude (model claude-fable-5-1) via Claude Code.
8. Mathih13

   closed this as completedin #401on Sep 3, 2026