Skip to content

A Shaman who dies with Reincarnation ready gets no Use Reincarnation button #11

Open

Description

@Mathih13

Expected (1.12.1). A Shaman who knows Reincarnation (20608), carries an Ankh (17030), and has the spell off cooldown sees a second button in the death dialog. Using it casts Reincarnation (21169), which revives the Shaman in place at 20% health and mana, consumes the Ankh, and starts the one-hour cooldown. cMaNGOS picks this option in Player::GetResurrectionSpellId from exactly those three conditions.

Actual (at 87109e3c). #618 built the Self-Resurrection Option for the Soulstone. At death the Module chooses the option only from the Character's Soulstone auras (self_resurrect.rs#L19-L32), so Reincarnation is never offered. The revive itself already handles Reincarnation's 20% vitals: a unit test pins spell 21169 (self_resurrect.rs#L147-L151).

How it shows. A dead Shaman with an Ankh sees only Release Spirit.

Fix direction. At death, also offer 21169 when the Character knows 20608, holds an Ankh and has no cooldown on 21169. On use, consume one Ankh and start the cooldown. The Soulstone keeps priority when both apply. The real-client checklist in docs/self-resurrection-client-check.md has not run yet for the Soulstone either; extend it with the Reincarnation case.

Activity

  1. changed the title [-]Implement Self Resurrect (SELF_RESURRECT-94): Soulstone[/-] [+]A Shaman who dies with Reincarnation ready gets no Use Reincarnation button[/+] on Oct 8, 2026
  2. added
    ready-for-agentComplete enough to build from the issue alone, by a person or their agent
    on Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2normalenhancementNew feature or requestready-for-agentComplete enough to build from the issue alone, by a person or their agent

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions