Repository navigation
refactor: split distill and graph endpoint modules (v2.59.3) - #302
Conversation
Moves the spaCy scoring patterns, _shape_score and the text helpers into core/distill_selection.py. Moved code is verbatim and distill.py keeps importing every name it exposed, so callers and tests are unchanged. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Moves the Console request and response models to graph_models.py and the project root, delete and memory-linking helpers to graph_projects.py. Moved code is verbatim. The delete-flow test now patches graph_projects, where those helpers are read. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (19)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (5)
🧰 Additional context used📓 Path-based instructions (3)Focus on tests that are flaky, non-isolated, incorrectly asserting behavior, or missing coverage for a changed high-risk path.⚙️ CodeRabbit configuration file Files:
Only flag documentation issues that are materially wrong, misleading for installation/release behavior, or inconsistent with live MCP behavior.⚙️ CodeRabbit configuration file Files:
Prioritize runtime correctness, async/concurrency safety, SQLite transaction safety, auth/rate-limit behavior, release-breaking packaging issues, and MCP protocol compatibility.⚙️ CodeRabbit configuration file Files:
🪛 ast-grep (0.45.3)marm-mcp-server/marm_mcp_server/core/distill_selection.py[warning] 151-151: XPath query is request-/variable-derived; use parameterized XPath to prevent injection. (xpath-injection-python) 🔇 Additional comments (19)
📝 WalkthroughWalkthroughThe pull request moves Distill selection helpers and graph endpoint models and project helpers into separate modules. It also updates release references and documented versions from 2.59.2 to 2.59.3. ChangesModule extraction and v2.59.3 release
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to The module split and version updates are ready to merge after normal checks. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Module Splits, Part 3 (v2.59.3)
Two more server modules over the file-length limit are split into smaller modules with no change in behavior.
core/distill.py(now 495 lines) moves its sentence scoring patterns,_shape_score, and the text cleanup helpers tocore/distill_selection.py.endpoints/graph.py(now 561 lines) moves the Console request and response models toendpoints/graph_models.py, and the project root, delete, and memory-linking helpers toendpoints/graph_projects.py.Moved code is verbatim, checked against the original with a line-multiset diff. The only test change retargets two patches in the project-delete test to
graph_projects, where those helpers are now read. The version moves to 2.59.3 with a changelog entry, andCONTRIBUTING.mdlists the new modules.The version-surface files (
settings.pyand the READMEs) overlap with open PRs #296, #297 and #300, so expect small conflicts on those lines when they merge.🤖 Generated with Claude Code
Summary by CodeRabbit