WIP: craft guide API support - #12
Open
CodingMantisUA wants to merge 1 commit into
Open
Conversation
Owner
|
Supporting craft guides is definitely a good thing, the more the better. Unless you beat me to it, I would like to extend this to my other mod, elepower, as well 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been working on VL's craft guide rework for some time. And now it provides API to register new tabs with custom recipe visuals. Changes for VL are in this PR
Before I'll polish it and get it merged, I'd like to collect feedback from potential consumers. In case I missed something, overlooked or just advice.
I was testing my changes and made this brunch not to loose progress. Visuals can be improved, but didn't spend much time on it.
Would be glad for any feedback. If you will have ideas of possible layout or behavior, fell free to share, I'll check if it can be implemented using current API or it should be extended.